From: David Marchand <david.marchand@redhat.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: William Tu <u9012063@gmail.com>, dev <dev@dpdk.org>,
Ranjit Menon <ranjit.menon@intel.com>
Subject: Re: [dpdk-dev] [PATCH RFC] net/virtio: Add virtio support for Windows.
Date: Tue, 17 Aug 2021 09:45:50 +0200 [thread overview]
Message-ID: <CAJFAV8xhjJYq6OZztcxWHCRTujgv7XTapUZMNsL0ZCrPnmrctA@mail.gmail.com> (raw)
In-Reply-To: <20210815224954.0bfa9266@sovereign>
On Sun, Aug 15, 2021 at 9:50 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> > diff --git a/drivers/net/virtio/virtio_pci_ethdev.c b/drivers/net/virtio/virtio_pci_ethdev.c
> > index 4083853c48..03e9dfab71 100644
> > --- a/drivers/net/virtio/virtio_pci_ethdev.c
> > +++ b/drivers/net/virtio/virtio_pci_ethdev.c
> > @@ -220,7 +220,9 @@ static struct rte_pci_driver rte_virtio_net_pci_pmd = {
> >
> > RTE_INIT(rte_virtio_net_pci_pmd_init)
> > {
> > +#if !(defined(_WIN32) || defined(_WIN64))
> > rte_eal_iopl_init();
> > +#endif
>
> I think rte_eal_iopl_init() should not be called from this PMD at all,
> because it is allready called by PCI bus driver before probing.
This call to iopl() must be kept in a pmd constructor (at least on
Linux) so that, for example, the interrupt thread inherits the IO
priviledge level.
>
> Also, DPDK code should use #ifdef RTE_EXEC_ENV_WINDOWS, etc. to test
> if it is building for a specific execution environment.
>
> > rte_pci_register(&rte_virtio_net_pci_pmd);
> > }
> >
--
David Marchand
prev parent reply other threads:[~2021-08-17 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 14:56 William Tu
2021-08-15 19:49 ` Dmitry Kozlyuk
2021-08-17 7:45 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xhjJYq6OZztcxWHCRTujgv7XTapUZMNsL0ZCrPnmrctA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ranjit.menon@intel.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).