From: David Marchand <david.marchand@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>,
Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>,
Thomas Monjalon <thomas@monjalon.net>,
Olivier Matz <olivier.matz@6wind.com>,
Kevin Traynor <ktraynor@redhat.com>,
Luca Boccassi <bluca@debian.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation
Date: Thu, 14 Oct 2021 21:16:42 +0200 [thread overview]
Message-ID: <CAJFAV8xi6DR+BtE-kesWCU0B+XhvFLmFXRpnPOD2Oc6=670Fqg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8z6Z1mPtbUOYA4JXPM32xaqLV5JU7h9abMtNCpKq3B_yQ@mail.gmail.com>
On Tue, Oct 12, 2021 at 9:57 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Oct 12, 2021 at 9:49 AM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
> >
> > On 10/12/21 10:28 AM, David Marchand wrote:
> > > If we do not enforce valid flags are passed by an application, this
> > > application might face issues in the future when we add more flags.
> >
> > Thanks. I'd even consider it as a bug and the fix to be
> > backported.
>
> I wondered too when writing the patch.
> I'd like to hear from others.
Backporting risks breaking existing applications which were validated
with potentially invalid flags.
So I won't mark it for backport.
I'll send v2 wrt to your other comment.
Thanks Andrew.
--
David Marchand
next prev parent reply other threads:[~2021-10-14 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 7:28 David Marchand
2021-10-12 7:49 ` Andrew Rybchenko
2021-10-12 7:57 ` David Marchand
2021-10-14 19:16 ` David Marchand [this message]
2021-10-12 10:10 ` Kinsella, Ray
2021-10-14 19:29 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-10-14 19:37 ` Stephen Hemminger
2021-10-15 7:02 ` Andrew Rybchenko
2021-10-15 8:26 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xi6DR+BtE-kesWCU0B+XhvFLmFXRpnPOD2Oc6=670Fqg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@oss.nvidia.com \
--cc=ktraynor@redhat.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).