From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D32CAA0C4E; Tue, 16 Nov 2021 21:24:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B30B540141; Tue, 16 Nov 2021 21:24:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1425040040 for ; Tue, 16 Nov 2021 21:24:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637094245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sn5HmvMDdzBQIpG19xLRcQmoybqF3wp0dPQ7qiDKz0U=; b=F6os6ZU2dAUmEuEYfi/+53ZE8DT5nEqpU5GiaK3yielSZLgacrjE/PiYMLAo+g6LNVehm1 ze0IeAI9WMdUn2Vfl2FbE4y89QePaR3CubUag8p2QDJIYEH5GC+LM9MfUnohRr487BaZ7o 9NdCOzW+brHn3fPqDoq4ZWlQGHRcSaQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-csf7-h9LNlmiZAWz0qKgtw-1; Tue, 16 Nov 2021 15:24:02 -0500 X-MC-Unique: csf7-h9LNlmiZAWz0qKgtw-1 Received: by mail-lf1-f70.google.com with SMTP id d2-20020a0565123d0200b0040370d0d2fbso71135lfv.23 for ; Tue, 16 Nov 2021 12:24:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sn5HmvMDdzBQIpG19xLRcQmoybqF3wp0dPQ7qiDKz0U=; b=w780+FSfFROD2s+nB1KjqKa45dFP+yRE20TtHNu7DcxE4h4hLEx1IZz3VoTPbcPARF YjsRT/MO50FbhmSh+SHQ1rjGcN0V5luNiQbF94OVG7oLWoAj4Ney8AtbHTELeiEm2W5r nZvs/EFgDTrU7dTBZV+YAXOjDZ0jTULTIYr78EoFvfGFzDlbd1q2poM4Ate2fMTlEcWZ n4trMCqVntgtZ8Mxl6me7j7N+Ln7pjsbTffPPzKt3PFPJwyceoKw7W0AfRWk2HNeLwHL DP+ItSWyfBR1lTswi05GHHTyDNr8ckiqO3ajJqkTU1wc7JiMpTtKtuZSXT+k4SkHJHjV Dtsg== X-Gm-Message-State: AOAM533uAHmsmXy7E0enK+jN4yaRjXqqGDDsj9RZV7ogmnlz2wpNz+xT RMvRI9VHWGk09jpZfwoqunlCqUfpKThdD5bUkdSRbmyKFzF8mNRjpzliPKCFUce7DrdBFLvmVWu 1eMqIOgZH6lE+jeEZqjo= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr9072255lfv.560.1637094240909; Tue, 16 Nov 2021 12:24:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5L1iGEG+wE+qaFZsiqh0srKekCr4UiKjVqF6fGB4Grf4C1loHqWbVWth0Qs3+aZEQt7P9RvORhmEMmjvPwPw= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr9072228lfv.560.1637094240753; Tue, 16 Nov 2021 12:24:00 -0800 (PST) MIME-Version: 1.0 References: <20211116094205.750359-1-joyce.kong@arm.com> <20211116094205.750359-13-joyce.kong@arm.com> In-Reply-To: <20211116094205.750359-13-joyce.kong@arm.com> From: David Marchand Date: Tue, 16 Nov 2021 21:23:49 +0100 Message-ID: Subject: Re: [PATCH v2 12/12] app: remove unnecessary include of atomic header file To: Joyce Kong Cc: Maryam Tahhan , Reshma Pattan , Cristian Dumitrescu , Xiaoyun Li , Olivier Matz , Anatoly Burakov , Honnappa Nagarahalli , Konstantin Ananyev , dev , nd , Ruifeng Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 10:44 AM Joyce Kong wrote: > > Remove the unnecessary rte_atomic.h included in app modules. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang After patch, I still see: $ git grep rte_atomic.h app/ app/test/commands.c:#include app/test/test_atomic.c:#include app/test/test_event_timer_adapter.c:#include I can undertand why the test_atomic would depend on rte_atomic.h :-) but not the rest. Is there a reason? or is it just a miss? -- David Marchand