From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D876AA0503; Thu, 19 May 2022 18:22:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76B1540222; Thu, 19 May 2022 18:22:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E252940156 for ; Thu, 19 May 2022 18:22:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652977329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knYvImWvt9JtGYq3e0ZTqMGgLVl2jeL9kpXzNWKmPdI=; b=WeoOGDjsW3cq4055FSdskVRT8ku4FNeHa9AZP6TUnzAsnstNAITvVy4b3IFHd8dyHFawDW gkY2+Rz7UiEy+SrccGoOel58o0mgMnvTr7Br21o0pbwaCFZ18m9DYGQAh3Bx/oRDZAT18K 28o3GaH+xgrfOIWSc716d3DJvrsnQ7U= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-612-kdBUSGKMOA-w8g-Xzb81bg-1; Thu, 19 May 2022 12:22:05 -0400 X-MC-Unique: kdBUSGKMOA-w8g-Xzb81bg-1 Received: by mail-lf1-f69.google.com with SMTP id g2-20020a0565123b8200b004725c7af360so2865604lfv.19 for ; Thu, 19 May 2022 09:22:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=knYvImWvt9JtGYq3e0ZTqMGgLVl2jeL9kpXzNWKmPdI=; b=rg71Y1AyH6QStxBcy+3HdLigUl05qx35LqCzns42kc5VzwIrshEDV68659+t5Zs82A 10YZnopaHBN2lLGpM3flK2JyRkiDUflEix4KDe5rtp6sttgonG9IvMvO6LTRlwAhXhzn K1Ly9Cq8z09YG3ABV72iS7/FtdXZhzBP33JDwbcMnqW2EEme42Dse/rGXOR9SBi8AaD2 HadnMUz7z5kRz5mxX2sjZFE02OChBDDoN9al14v2ok0shnYImRjKyJLZalwfJc2bAwMM N1NcYi60HZVX54XSiNroukFcUKbZ0ffBUV7lYX3cu9UFu+0XgRgFsyfhrkhwNVrtIS1p sxOQ== X-Gm-Message-State: AOAM5310COGit2OuAJ6b3+fyySsiHsPyPJC/LLqQ2TeOAhfqj+uiQjWJ YEM6plQy33jpKvtVIWUKgCVJHSLZcm0H6KjuU/rbUiBMQL2E/ApUg4N3ImwoH/Y/VNtTr8YxAKy nZh6h77YTGvO6bnHfz8s= X-Received: by 2002:ac2:5a19:0:b0:477:c124:41fe with SMTP id q25-20020ac25a19000000b00477c12441femr3783334lfn.553.1652977323158; Thu, 19 May 2022 09:22:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfQoC06NCuEwb6obel4W6tJ7l35Fa+RsPpx6Y5jTMBucSrQknjbyfduk5TezR2q/XhItJch75X0RFSPv9peBc= X-Received: by 2002:ac2:5a19:0:b0:477:c124:41fe with SMTP id q25-20020ac25a19000000b00477c12441femr3783320lfn.553.1652977322933; Thu, 19 May 2022 09:22:02 -0700 (PDT) MIME-Version: 1.0 References: <20220414112756.26119-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 19 May 2022 18:21:51 +0200 Message-ID: Subject: Re: [PATCH] devargs: fix leak on hotplug failure To: Xueming Li , Gaetan Rivet Cc: dpdk stable , dev , Ray Kinsella , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 12, 2022 at 9:06 AM David Marchand wrote: > On Thu, Apr 14, 2022 at 1:28 PM David Marchand > wrote: > > > > Caught by ASan, if a secondary process tried to attach a device with an > > incorrect driver name, devargs was leaked. > > > > Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Review please? No objection, the fix has been around for one month. Applied. -- David Marchand