From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 067C442278; Fri, 1 Sep 2023 16:30:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 976FB40285; Fri, 1 Sep 2023 16:30:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 066EB4014F for ; Fri, 1 Sep 2023 16:30:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693578605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A1LeHVWoZOGLM5bFMcLv7lPUHlZRt+0Cd7BUGPUIEac=; b=VRagzVzzjLGPYXwHioYXAe5VMmz8d4Wx2WZ4GIto3iVgqszsfsW2Izueglmg86gIYMnmac 8XIW+nHHYny2lTKi24uU2N3bdNueFJfy18dIuSVj2AR78SUbZX2Fj4mP3mOmwfOGbHdgn4 3XEK6wIk071iZ5QvgIFf7zaTBo4mNlQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-Z1_FJmIhM3eSn-vDtfg5Mw-1; Fri, 01 Sep 2023 10:30:04 -0400 X-MC-Unique: Z1_FJmIhM3eSn-vDtfg5Mw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50092034189so2506939e87.3 for ; Fri, 01 Sep 2023 07:30:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693578602; x=1694183402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A1LeHVWoZOGLM5bFMcLv7lPUHlZRt+0Cd7BUGPUIEac=; b=J3uJkizCyWUwLhODy4bmiBse4JehcOFVYWjtWzggZj6NEu4tpcmoWm9IjKO7yDDaFj cF6xoDoQOh4floOKg2fipRsHNAkqKbKgWBxYbWhfGs2AhffxunSM5CYc04NjuY3hsVCV bMiyqcjo5D+6+PlOCWqANbIQiphJAzpCQUHuf7VK/CTwdjV2cwMyLoXrIgJBdQbNotnn dw3Mc+5U/S9TAhB0aCB+h/33gxY7Il0l74lAngRlvCcDeHGtyhj4yF5gUcLriQ4MDqTC 53k2pJfCoBuQTvrXTfy814Bwgo6KoFxUa6Y6roEYnWr2QHIcTxJi0IeBiM9fV+l6Sy7a zcZA== X-Gm-Message-State: AOJu0YyWMHbQ5XrZOao6u/EQKjE5FiFsEt5Zt6BdMpZVmIB0y3nTQuaD B9iQvhHSqJVOAVq+LsW7DvHSH50kAoRVE0SGFCfv/7xER9w0FN7Mm3XbUbZkB/adrJWeqt38FvZ AeqRMxlxPlbXW3lfrNnnxkQu7rRo= X-Received: by 2002:a05:6512:3d0e:b0:4ff:9a75:211e with SMTP id d14-20020a0565123d0e00b004ff9a75211emr2413521lfv.42.1693578602024; Fri, 01 Sep 2023 07:30:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEAlrrM4Riphx73VWVljND1OF7K/2VsUm3hUiZkvtO5UYlOw+QfuNETt1uchqRNtEuW1YB39rbB7aJLFAQhydA= X-Received: by 2002:a05:6512:3d0e:b0:4ff:9a75:211e with SMTP id d14-20020a0565123d0e00b004ff9a75211emr2413500lfv.42.1693578601705; Fri, 01 Sep 2023 07:30:01 -0700 (PDT) MIME-Version: 1.0 References: <20230901142332.588856-1-bruce.richardson@intel.com> In-Reply-To: <20230901142332.588856-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 1 Sep 2023 16:29:50 +0200 Message-ID: Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 1, 2023 at 4:23=E2=80=AFPM Bruce Richardson wrote: > > When the user passes a list of desired libraries to build via the > "enable_libs" option, the expectation is that those libraries should be > part of the build. However, if those libs have either external or > internal dependencies, they still may be silently disabled, for example: > running "meson setup -Denable_libs=3Dsecurity build" will successfully > run, but the security lib will not be configured as "cryptodev" is > missing. > > We can fix this by setting a flag to indicate when the libraries are > specified via an enable_libs flag. If so, then we error out when a > library is unbuildable, giving a suitable error message. For the above > example case, the "meson setup" run fails with: > > Message: Disabling security [lib/security]: missing internal dependency "= cryptodev" > > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicit= ly requested lib "security". > Please add missing dependency "cryptodev" to "enable_libs" option > > Signed-off-by: Bruce Richardson I remember setting a enable_drivers=3Dnet/af_xdp on a system lacking libbpf-devel and not getting warned about its absence. So I suspect enable_drivers is affected by the same issue. --=20 David Marchand