From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53E05A0350; Wed, 1 Jul 2020 11:20:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5DAC1C2AA; Wed, 1 Jul 2020 11:20:08 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id D308D1C222 for ; Wed, 1 Jul 2020 11:20:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593595207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DHtvTMB6bqjy6BwzrYVrg7BEM8dMj3A0H+u50lmxbmQ=; b=VcvHGSaV3LaWcVFPTt2yF1jfZafeoVIbSuzS+Q4UgTskfHWgBLnqvPIqHhKf3hsY+bTNxk NQEAKN3toNHYkkNFQaXXit0NYv1j+yGmifHV+RsyFlt2WL+PzUO/WL70LoB4A2eJFZxijd 1dMXfVwN5TrtiOCS0Dyq4sWy0DmQttE= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-36C3-hVjOpKn2YDzWaW2-g-1; Wed, 01 Jul 2020 05:20:05 -0400 X-MC-Unique: 36C3-hVjOpKn2YDzWaW2-g-1 Received: by mail-vs1-f71.google.com with SMTP id p124so2289997vsp.4 for ; Wed, 01 Jul 2020 02:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DHtvTMB6bqjy6BwzrYVrg7BEM8dMj3A0H+u50lmxbmQ=; b=gSfXfafo9Mx1j0qbCXacLs/4KqgHk48L7Rz5qwodF+1wJbgBaMf4sE9cdJx6LzKXR/ +iJ6w4u4QG34rAF3VoH5P3xIuTCZW9H4aDsZ/rlgUF9oj7P8QvVKmRcEaJ00i2D+0+ik CznFy35YD+wVBIus72IHYKCyhyxd5HIqjT2h4tThgr8Y98ZBcJ0084oWWuK8M49CnPfq yOo8fj6TO5aaLL9Vbr0zT4KppmmNeXm1/3xcITph5SLPJxQl6e/NOd/zGpJxCcxEd7ap v7y613J5HFA1Dkj1rNArxCIHSLCa+tEgiwXUHBMJe9cyvCvON0zjkEfwt3zJhDKovEco GnQg== X-Gm-Message-State: AOAM530ViANl3HUqSb0Lfn53U34+Lz4veoe0vR0MyFdGay2SoIX4fVQa lufxcQhYTZ4yQ/PpLVqk3IV4qpN6hfklLn2DlJEfrB0/fg/GIQNyBrdJTaGMrPQqSNNew53kp7O cRw1dcNn6xsxjD1b7T2o= X-Received: by 2002:a67:26c2:: with SMTP id m185mr17612094vsm.39.1593595205258; Wed, 01 Jul 2020 02:20:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdmEBofuaH4+GPHWl/GYzJ88Z0tUawwrqdhmFN84IbHX7g1ryWq18Dz73pd2BSavl/ie0KKvUie5Mz4J7yrH0= X-Received: by 2002:a67:26c2:: with SMTP id m185mr17612087vsm.39.1593595204935; Wed, 01 Jul 2020 02:20:04 -0700 (PDT) MIME-Version: 1.0 References: <20200513153111.37063-1-mb@smartsharesystems.com> <20200519152725.63486-1-mb@smartsharesystems.com> <20200519152725.63486-3-mb@smartsharesystems.com> <20200519085223.079bc2ac@hermes.lan> <98CBD80474FA8B44BF855DF32C47DC35C60FDD@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60FDD@smartserver.smartshare.dk> From: David Marchand Date: Wed, 1 Jul 2020 11:19:53 +0200 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Stephen Hemminger , Olivier Matz , "Ananyev, Konstantin" , Honnappa Nagarahalli , nd , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] ring: empty optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 19, 2020 at 6:02 PM Morten Br=C3=B8rup wrote: > > Blank line after declarations? > > > > Are the temporary variable even needed? > > Personally, I agree with you, but I was trying to match the existing codi= ng style of the closely related rte_ring_count() function - only to avoid t= his kind of feedback. > > Damn if you do, damn if you don't. :-) Yes, looking at the code, it seems fair taking this patch as is. --=20 David Marchand