From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DE45460FC; Thu, 23 Jan 2025 14:03:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A0A140269; Thu, 23 Jan 2025 14:03:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8411C40263 for ; Thu, 23 Jan 2025 14:03:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737637425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kwqUy8+WWLrPsyu4oDDFmCGMeB4/C1ufAzQN7zxt1MM=; b=CBBBI90ANSn4xSqnFesypUSvD/B5iimdqGPVZZEehNR/W6QDLbd0ABStUlusXbGLx9l6vb xJCQo9ltox0GGXSusUnAGQftY2X+Vft3VPuAvaG1b+vnQY5FkT8ltvv9EcgcFuV3kFEa+U GMqeqVejJAz+meWJB4bYROo/eDi4ejA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-lMnukcYRNSm04IH-MroDzw-1; Thu, 23 Jan 2025 08:03:43 -0500 X-MC-Unique: lMnukcYRNSm04IH-MroDzw-1 X-Mimecast-MFC-AGG-ID: lMnukcYRNSm04IH-MroDzw Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-3022cd152cdso5081441fa.1 for ; Thu, 23 Jan 2025 05:03:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737637422; x=1738242222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kwqUy8+WWLrPsyu4oDDFmCGMeB4/C1ufAzQN7zxt1MM=; b=HGX9C1paYWsatjq7u+wVKESDYD3FrwYpnywy6PTpetHb7MfTzJ2t/LTTas5GFKR1wn 51GBCNT3Gy0ZRyKDpEFlW/pvA21nFTa1IJQqXRxYgY6qSc48jlrxqvxMHA6Fn3lo75oU dZ8S5LXkDCqoVKhnEQsDYlItlEMFeA85vPt8NKHrxKZQPIxdHSm3+zcV1siHw0RDVSx/ h16fXTzRt8mix6xYRccgw8+5WqyL5MpOLqRPJQFJ/IkbMW1t4Agqyubyixc7OGKS1Eex 9v76gnE2MXolih9zTF+2djynbBTE5SbV6VRDy+9qG/CICmemW/mbYcz803NQiQ/2ADtS 5aWg== X-Forwarded-Encrypted: i=1; AJvYcCXu7OjSYu5RofDnEbTTSJI/THZG8r495PMliufrxDnV/5nL5Y1B2CaM0xzkEb1cgw2ITc0=@dpdk.org X-Gm-Message-State: AOJu0YwHrSMzkxrLc1f0FBzbr6gWZ1kpMWJ96oBHm3RBMLogAEVG2YZA CIYG3B+q42gAN/EjqmpdXDbo/E7JJu1TJU0SpmFqQ4u756wvI4S4qDD+rGAcvxqTOJDRTvflppf mexcvlEkSwa5R9oF9mSnbhVaQFNlrb1Cf0IBrkG5F8nBeiXc8we/BDoNMO1yIfPeeckoCkc9HTc qTU3c4PR0tk4lNLZs= X-Gm-Gg: ASbGncvAnpg9/6M60n1Mz7ORaPsP3jLSuWTVaWK833lVXybqUYq7csFlqZmg0aUg82K ZwgUKVdaktH82DZ38ZPDEd/2X+lGHtiQFyAMfU5eT1Fmzz11KKwE82Q== X-Received: by 2002:a2e:a883:0:b0:306:188f:c0b3 with SMTP id 38308e7fff4ca-3072cb3cf7amr94923471fa.35.1737637421953; Thu, 23 Jan 2025 05:03:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFy87WPg35/5aEkfDnXvJF+4OTheR1qadVgyzGVYZXTGSdE0oLAel0ml2cIk8FbvLeHr6Ue7Qzv4FVBmdEe2Zg= X-Received: by 2002:a2e:a883:0:b0:306:188f:c0b3 with SMTP id 38308e7fff4ca-3072cb3cf7amr94923151fa.35.1737637421518; Thu, 23 Jan 2025 05:03:41 -0800 (PST) MIME-Version: 1.0 References: <1735254890-18457-3-git-send-email-andremue@linux.microsoft.com> <1737559244-9107-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: From: David Marchand Date: Thu, 23 Jan 2025 14:03:29 +0100 X-Gm-Features: AbW1kvZV-JQOma8qsuzifI4p_DfYxIk47pptzVTvevzu5d77jcdb6s1kW6jrYdc Message-ID: Subject: Re: [PATCH v2 0/2] fix void function returning a value To: Bruce Richardson Cc: anatoly.burakov@intel.com, Andre Muezerie , dev@dpdk.org, thomas@monjalon.net, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ziG6_wfFjAcbbeoHAE8KE5J0zxjUUdRtmxmZszlCwAo_1737637422 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 1:46=E2=80=AFPM Bruce Richardson wrote: > > On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote: > > Hello Bruce, > > > > On Wed, Jan 22, 2025 at 4:21=E2=80=AFPM Andre Muezerie > > wrote: > > > > > > v2: > > > * Updated commit messages to follow standard format. > > > > > > This patch avoids warnings like the one below emitted by MSVC, and is > > > needed to get the code to compile cleanly with MSVC. > > > > > > ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139): > > > warning C4098: 'idpf_singleq_rearm': > > > 'void' function returning a value > > > > > > Andre Muezerie (2): > > > drivers/common: fix void function returning a value > > > drivers/net: fix void function returning a value > > > > > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 12 ++++++++---- > > > drivers/net/i40e/i40e_rxtx_vec_avx2.c | 2 +- > > > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- > > > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 2 +- > > > drivers/net/ice/ice_rxtx_vec_avx2.c | 2 +- > > > 5 files changed, 12 insertions(+), 8 deletions(-) > > > > I see the series is delegated to the main repo (Thomas). > > > > This touches only Intel drivers and the code deduplication effort you > > started may conflict (though trivially) with such changes depending on > > when it lands. > > > > Would you mind merging this fixes from Andre through the > > next-net-intel tree, right now? > > If so, please mark it as delegated to you in patchwork. > > > > > > Thanks! > > > Hi David, > > the code deduplication effort patchsets are similarly delegated to the ma= in > repo. I was assuming this was deliberate, but perhaps it isn't? I'm ok to I suspect it was delegated to main because of the change on devtools/check-git-log.sh. But it is really only about net driver changes, so it should go either through your or Stephen tree. (we have enough patches waiting in main ;-)) > take these patches in next-net-intel, but just would like to confirm that > neither you, Thomas or Stephen (as net maintainer) want to review the ded= up > work ahead of that initial merge? I don't have an objection on this series (on the contrary, I am quite happy to see such effort). I'll have a deeper look at it, this afternoon. --=20 David Marchand