From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A641645B01; Thu, 10 Oct 2024 12:00:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85C4A4064A; Thu, 10 Oct 2024 12:00:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E5D9402D9 for ; Thu, 10 Oct 2024 12:00:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728554429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIDiez+m7DZJQEabgezmYI3VGD+Z24qNDWfX2oFZmac=; b=IiBEHGm3lkjrdfOxq379Ab6OrdtyaMPe0CrHIsHPojE+7wnkYdoZoE96/1GxXg/F5uTYTO yhsFu1p3y+y/FlXJ8vijv+ZZ7Sb3+0BjrK9ZS/WhY/Ae8raOI5Gpvyof8fFW1yxlkBomFp pYfzoDC4wi9KzGSvb1PF3qroe9hNk/c= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-RNtlpXk8MvOg7XakleN6WQ-1; Thu, 10 Oct 2024 06:00:28 -0400 X-MC-Unique: RNtlpXk8MvOg7XakleN6WQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539c2b197ceso622790e87.0 for ; Thu, 10 Oct 2024 03:00:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728554427; x=1729159227; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yIDiez+m7DZJQEabgezmYI3VGD+Z24qNDWfX2oFZmac=; b=N7Q7ZfcUlhJhkqWHvXMO3AUa63XL9kXk5TH/BDr8sMT0p2/1oerXRme04hPF5R6vH5 DWUWHTdV8iNQOFG1SAwJpsREBFl/JZxZ4zdmSlkcj4MUitqrhP6VJzfguBBssmA4D2b0 z60JGXvD18SiGfzsRNIAvQ6l8FYifmXlO6wVjVAuNxumfT5pcxWkTyrnvwTaKBTrW6uD N/ZaRY0ctmcSEpjyS1vOybAE7Sw5i9F0ybbu/gGPKD6kXPMDyhFSm2DPBh7khQHkLouh Mo27iyO1e1xi2y2tTS5emHVAPkEVJrSg+97rxORYa+vMzSmwiOEwefsWDLVdxU/UwqYn RINw== X-Forwarded-Encrypted: i=1; AJvYcCW937KViKdxQ51XV0izr5H3iQ5pvxbH0D5ipQRf+NSjxhs9xntpSxQzkt6K2YxxEMP58Fk=@dpdk.org X-Gm-Message-State: AOJu0YyZg9TR2bCfDVQ2k1UYmk8NjMUDjya0PGsiNHWM+0Ri99fS/yRB MWacBFiTfBkDeTZMVyRTQ+oKL/txSKqAYFTX+6X4+t5Dd5eDgEoM9gWORuS0Sc1ywxQAE/H5XnE H1BE24rz8joyI1aZ5WywQPEu1aONlZIoU6T7U9ZaTk4ChDyKwCQtmZCY2Eo9Efn5zIbjuaeclv+ DCN0iVJbJXv15gBEw= X-Received: by 2002:a05:6512:6ca:b0:536:52c4:e45c with SMTP id 2adb3069b0e04-539c48dd442mr3829813e87.31.1728554427095; Thu, 10 Oct 2024 03:00:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEIk6SFcgvtTTTam4Cz9gT+mYecmhfPQJaCoqYXn9sHyPS4Ru5Thw84mbmt4Xn+uKRq4AB/ObSqL4RMrzvJW4= X-Received: by 2002:a05:6512:6ca:b0:536:52c4:e45c with SMTP id 2adb3069b0e04-539c48dd442mr3829788e87.31.1728554426666; Thu, 10 Oct 2024 03:00:26 -0700 (PDT) MIME-Version: 1.0 References: <1721331448-9225-1-git-send-email-longli@linuxonhyperv.com> In-Reply-To: <1721331448-9225-1-git-send-email-longli@linuxonhyperv.com> From: David Marchand Date: Thu, 10 Oct 2024 12:00:15 +0200 Message-ID: Subject: Re: [PATCH] eal: fix device unregister for event registered with device_name NULL To: longli@linuxonhyperv.com Cc: Tyler Retzlaff , dev@dpdk.org, Malcolm Bumgardner , stable@dpdk.org, Long Li , Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 18, 2024 at 9:37=E2=80=AFPM wrote: > > From: Malcolm Bumgardner > > In the device event unregister code, it unconditionally remove all > callbacks which are registered with device_name set to NULL. This results > in many callbacks uncorrectly removed. > > Fix this by only removing callbacks with matching cb_fn and cb_arg. > > Fixes: a753e53d517b ("eal: add device event monitor framework") > Cc: stable@dpdk.org > > Signed-off-by: Malcolm Bumgardner > Signed-off-by: Long Li Reviewed-by: Stephen Hemminger Applied, thanks. --=20 David Marchand