From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40EA8A0547; Thu, 28 Oct 2021 19:16:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 031F740DF4; Thu, 28 Oct 2021 19:16:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 285F340DDB for ; Thu, 28 Oct 2021 19:16:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635441407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FKQcwFFMAW5R02EpufMaATuMdK5Tbm6Yijq8dB7P6d4=; b=cViG551SxmECkAXCWBydItNl4khVxjFj1vxZGCZbt2Wy+8tsAmjq4luRSl3vppt5XUuEEq 7ILFrcZHb2XZBf6DB5Yc3ZJhMBtKi0NCA1sszvUGVA6NmA5OLzCk86vsvaHt0/oEBVbOe8 J1Nt5pPz7qksSeuQwpD5V4ZnPt2he1Q= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-Ox_l3MV-NN2Br6CRm3CJGA-1; Thu, 28 Oct 2021 13:16:27 -0400 X-MC-Unique: Ox_l3MV-NN2Br6CRm3CJGA-1 Received: by mail-lf1-f71.google.com with SMTP id x17-20020a0565123f9100b003ff593b7c65so3123784lfa.12 for ; Thu, 28 Oct 2021 10:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FKQcwFFMAW5R02EpufMaATuMdK5Tbm6Yijq8dB7P6d4=; b=eLoUIXD8t+TuC6HjXvMT6DSDnVeiHjU40E0qpbPkW0R7NuDI2pKegBJoOgDASQ5/Kd 5dGKcCnYXEOxOsP3FaeVYmDqZUBUP0xp0B4GNXQzrAKCabwG4b9VIzN0vzZM58TuUDmR YYraqDVjVMHQRSe8IeLNHiFBhKzFXqFsWCwdRWivgVSu2UV6GZoRoD63DAWXNA5NFQtN EnGOJX0YqhTVkd96mjN72bVDkmqWh3Y09YqdxwFzAOT9at8KL5lUY8tx6/Wy540T8aOx G33x68ZOvBAqU7wViI00p7Q+nD0bPShjU7uQxtS5awLg9ne8uGhQWFC4qoAPDoUv1qM0 YSbA== X-Gm-Message-State: AOAM533oBQZ+AWh1/BnCElXk/K1IhyIv8kB960zCur9nQxJ+WZxg/vNx yvFUJUISJ877GB+ykrLInFSW6ICB7RWr7Vnbxw9lipAWclJrKKpNWF1wcswGgH73iqildCnpAu8 9CgYjcoAt10U1gKDHNPE= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr5203735lfv.560.1635441385464; Thu, 28 Oct 2021 10:16:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMCPRAgD8/12JYJbEEP8ZbCtmUDz0DDf9RDrYk8WGDN30k6IVrFz8jyNAgXaOtqmGav4j8n8Przy4N8Aj8cf8= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr5203702lfv.560.1635441385221; Thu, 28 Oct 2021 10:16:25 -0700 (PDT) MIME-Version: 1.0 References: <20211022204934.132186-1-hkalra@marvell.com> <20211025142712.1273-1-david.marchand@redhat.com> <20211025142712.1273-10-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 28 Oct 2021 19:16:13 +0200 Message-ID: To: "Ji, Kai" , "hkalra@marvell.com" Cc: "dev@dpdk.org" , "dmitry.kozliuk@gmail.com" , "rasland@nvidia.com" , "thomas@monjalon.net" , "Burakov, Anatoly" , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "Mcnamara, John" , "Yigit, Ferruh" , "Ananyev, Konstantin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 9/9] interrupts: extend event list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 28, 2021 at 5:58 PM Ji, Kai wrote: > This patch is causing QAT failed during interrupt init, the event list does not support interrupt count size zero in QAT case. > > There is also Bugzilla relate to this issue: https://bugs.dpdk.org/show_bug.cgi?id=843 (We could avoid updating event list if it is large enough but) your problem must be that QAT does not have MSIX. Can you try this quick fix? diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c index f622e7f8e6..13733d03f3 100644 --- a/drivers/bus/pci/linux/pci_vfio.c +++ b/drivers/bus/pci/linux/pci_vfio.c @@ -269,7 +269,8 @@ pci_vfio_setup_interrupts(struct rte_pci_device *dev, int vfio_dev_fd) /* Reallocate the efds and elist fields of intr_handle based * on PCI device MSIX size. */ - if (rte_intr_event_list_update(dev->intr_handle, irq.count)) + if (i == VFIO_PCI_MSIX_IRQ_INDEX && + rte_intr_event_list_update(dev->intr_handle, irq.count)) return -1; /* if this vector cannot be used with eventfd, fail if we explicitly -- David Marchand