From: David Marchand <david.marchand@redhat.com>
To: Ibtisam Tariq <ibtisam.tariq@emumba.com>
Cc: "Kovacevic, Marko" <marko.kovacevic@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Xiaoyun Li <xiaoyun.li@intel.com>, dev <dev@dpdk.org>,
jijiang.liu@intel.com
Subject: Re: [dpdk-dev] [PATCH 8/8] examples/tep_termination: enhance getopt_long usage
Date: Thu, 29 Oct 2020 14:16:39 +0100 [thread overview]
Message-ID: <CAJFAV8xktjEHbekUoSyoQWFMMARvLP51r9v5r5cMfr_KR0Rm_w@mail.gmail.com> (raw)
In-Reply-To: <20201029125339.30916-8-ibtisam.tariq@emumba.com>
Hello Ibtisam,
On Thu, Oct 29, 2020 at 1:58 PM Ibtisam Tariq <ibtisam.tariq@emumba.com> wrote:
>
> Instead of using getopt_long return value, strcmp was used to
> compare the input parameters with the struct option array. This
> patch get rid of all those strcmp by directly binding each longopt
> with an int enum.
>
> Bugzilla ID: 238
> Fixes: a50245ede7 ("examples/tep_term: initialize VXLAN sample")
> Fixes: 2bb43bd435 ("examples/tep_term: add TSO offload configuration")
> Fixes: 39c6daca9b ("examples/tep_term: add UDP tunneling port configuration")
> Fixes: 9b96dd2609 ("examples/tep_term: add inner checksum Tx offload configuration")
> Fixes: e627e8843d ("examples/tep_term: add tunnel filter type configuration")
> Fixes: c6a0fb5f54 ("examples/tep_term: add encap/decap configuration")
> Cc: jijiang.liu@intel.com
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
This patch can be dropped.
Thomas just merged this example removal.
--
David Marchand
next prev parent reply other threads:[~2020-10-29 13:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 12:53 [dpdk-dev] [PATCH 1/8] examples/fips_validation: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 2/8] examples/l3fwd-acl: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 3/8] examples/packet_ordering: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 4/8] examples/performance-thread/l3fwd-thread: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 5/8] examples/qos_sched: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 6/8] examples/vhost: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 7/8] examples/vhost_crypto: " Ibtisam Tariq
2020-10-29 12:53 ` [dpdk-dev] [PATCH 8/8] examples/tep_termination: " Ibtisam Tariq
2020-10-29 13:16 ` David Marchand [this message]
2020-11-02 8:18 ` Ibtisam Tariq
2020-10-29 22:07 ` [dpdk-dev] [PATCH 1/8] examples/fips_validation: " David Marchand
2020-11-02 8:32 ` Ibtisam Tariq
2020-11-04 10:00 ` Ibtisam Tariq
2020-11-05 8:59 ` David Marchand
2020-11-10 6:10 ` Ibtisam Tariq
2020-11-10 8:23 ` David Marchand
2020-11-10 9:03 ` Ibtisam Tariq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xktjEHbekUoSyoQWFMMARvLP51r9v5r5cMfr_KR0Rm_w@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ibtisam.tariq@emumba.com \
--cc=jasvinder.singh@intel.com \
--cc=jijiang.liu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=reshma.pattan@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).