From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess
Date: Mon, 14 Oct 2024 20:58:13 +0200 [thread overview]
Message-ID: <CAJFAV8xkxsPsm93QnznwwoLCKh87rp6b0XUonJ6SAyGaVd3xmQ@mail.gmail.com> (raw)
In-Reply-To: <a913b44b-9761-48e8-a3dc-985b36afaac6@redhat.com>
On Tue, Sep 17, 2024 at 10:20 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> > At the moment, if VFIO is not available at DPDK init, it won't be
> > available unless a subsequent rte_vfio_enable() is done.
> >
> > Yet, even if rte_vfio_enable() is called again in primary and secondary
> > processes, a secondary process will never get to know that VFIO has been
> > enabled in the primary process as the MP requests handler is only
> > registered in EAL init.
> >
> > On the other hand, moving the MP requests handler registration earlier
> > in EAL init is ok, as secondary process are supposed to be waiting on
> > eal_mcfg_wait_complete() until the primary process calls
> > eal_mcfg_complete().
> >
> > Move vfio_mp_sync_setup() in rte_vfio_enable().
> >
> > Besides, rte_eal_vfio_setup() is useless and its name with a rte_ prefix
> > is ambiguous as it gives the impression it is an exported/public symbol.
> > Remove it and directly call rte_vfio_enable() where needed.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Series applied for rc1.
Thanks for the review Maxime.
--
David Marchand
next prev parent reply other threads:[~2024-10-14 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 12:30 David Marchand
2024-09-16 12:30 ` [PATCH 2/2] bus/pci: enhance hotplug for VFIO bound devices David Marchand
2024-09-17 8:57 ` Maxime Coquelin
2024-09-17 8:20 ` [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess Maxime Coquelin
2024-10-02 18:31 ` David Marchand
2024-10-03 8:25 ` Kevin Traynor
2024-10-14 18:58 ` David Marchand [this message]
2024-10-04 14:34 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xkxsPsm93QnznwwoLCKh87rp6b0XUonJ6SAyGaVd3xmQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).