From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A36B142DAF; Mon, 3 Jul 2023 13:38:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BBED40EF0; Mon, 3 Jul 2023 13:38:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D2D6740ED5 for ; Mon, 3 Jul 2023 13:38:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688384334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ibEf1JYIhAtQBxjAvHbo+SdAfHxR1atsBk5W1W/+x0g=; b=ZyPXou+CkmbTo5/O5vQN0+QJilU71TcKLGBv5JaRj3dAIID/pf3Ktqh9Y+3Z8FgeSIAfgD VjvJMMfUgF3ah1FWS9CM8oYYeb7Z7zFHj52HzivHWuBBaCkBJ2AYZeH7Wt+UepIYMOleDY 1kJWf14hFMtsdAp2xM3Iea6P80XhLUw= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-5S7RKA5xOsedjOH_YRhFfQ-1; Mon, 03 Jul 2023 07:38:53 -0400 X-MC-Unique: 5S7RKA5xOsedjOH_YRhFfQ-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-262e619fbd0so4352653a91.0 for ; Mon, 03 Jul 2023 04:38:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688384332; x=1690976332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ibEf1JYIhAtQBxjAvHbo+SdAfHxR1atsBk5W1W/+x0g=; b=KLrZcrTEDBzsR2QOIApkRUpQ+LedbgtNXg9/Hhlhuk20XxMcV/Ngf3U+32aoWi+0st RLrZegyLSrLAoRYzTw/TZhPnb8ZaXADPEsxCq34ySFwmwt0qIFna1j+KHcTXp+PfSLlG LkTpKRyAgPTbzRbwwtt3e3e6tALDYe8icTZEoODlou5f0h3Iq0IOU+NWucoywruPaVFN er1YRr9J2NAoXls0DnNfxM+6jCQIaB0u82NriZUAxg+x5KnQadqhcfxPm4ce/6zJm5fi hANGvNFOrLL/27OhNwkS08x9Oywebs07rEcHKG6KmGH4soR3jG6y2eCUucspU8l2qFgt l4mg== X-Gm-Message-State: ABy/qLbRNMK/YBuZ5Wp1NCMdH3D0OV5AE7b0KMmtQjQjxf9A8Vke8F+K 2dI91iQNVe7H7emyvYf5uiTqL7Qj2OjYGhU4r6RbwlD3Qo/p03ZS7a0iV9uEnEsTCJKabhWkz9p I4RTwIFwXQYUNVGpnuIE= X-Received: by 2002:a17:90b:268b:b0:263:eef:1465 with SMTP id pl11-20020a17090b268b00b002630eef1465mr8286248pjb.44.1688384332234; Mon, 03 Jul 2023 04:38:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlFUYIox5wDXggxaIoNdYU68YegzHJkap93CfHFXX/0SSbm3sYGE0It+i0Mdluf3CJHVUBZ2BcPmQF43PHpKwHY= X-Received: by 2002:a17:90b:268b:b0:263:eef:1465 with SMTP id pl11-20020a17090b268b00b002630eef1465mr8286238pjb.44.1688384331957; Mon, 03 Jul 2023 04:38:51 -0700 (PDT) MIME-Version: 1.0 References: <20230703112359.5067-1-thomas@monjalon.net> In-Reply-To: <20230703112359.5067-1-thomas@monjalon.net> From: David Marchand Date: Mon, 3 Jul 2023 13:38:40 +0200 Message-ID: Subject: Re: [PATCH] set namespace prefix to threads To: Thomas Monjalon Cc: dev@dpdk.org, Timothy McDaniel , Shepard Siegel , Ed Czeck , John Miller , Rosen Xu , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , Tianfei Zhang , Xiao Wang , Maxime Coquelin , Chenbo Xia , Anatoly Burakov , Bruce Richardson , Harman Kalra , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Naga Harish K S V , Jerin Jacob , Ciara Power X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 3, 2023 at 1:24=E2=80=AFPM Thomas Monjalon wrote: > > When looking at threads in a system, it can be confusing > to find some unknown threads without a clue it is started by DPDK. > > Let's start all thread names with "dpdk-" > and the driver name if it comes from a driver. > > One more constraint: the thread names are generally limited > to 16 characters, including NUL character. Yes, and no way to discover this limit. > > Signed-off-by: Thomas Monjalon > --- > Please review carefully, I may have missed things. > > Note: we should use rte_ctrl_thread_create() as much as possible. > As for this comment, we should advertise rte_thread_create_control() instead, as it is thread library agnostic. Which leads me to suggest looking at rte_thread_create_control() calls too. > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > index 7008303e11..e201acd1c2 100644 > --- a/lib/eal/freebsd/eal.c > +++ b/lib/eal/freebsd/eal.c > @@ -843,7 +843,7 @@ rte_eal_init(int argc, char **argv) > > /* Set thread_name for aid in debugging. */ > snprintf(thread_name, sizeof(thread_name), > - "rte-worker-%d", i); > + "dpdk-worker-%d", i); > rte_thread_set_name(lcore_config[i].thread_id, thread_nam= e); > > ret =3D rte_thread_set_affinity_by_id(lcore_config[i].thr= ead_id, We changed this not so long ago with 8ae946970ed3 ("eal: fix thread name for high order lcores") which offered up to 4 digits for lcores. With your proposal, we are back to only 3 digits, which is probably enough, but I preferred to raise it. --=20 David Marchand