From: David Marchand <david.marchand@redhat.com>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <yanzhirun_163@163.com>
Subject: Re: [PATCH] graph: enhance export to graphviz
Date: Tue, 18 Jun 2024 15:15:50 +0200 [thread overview]
Message-ID: <CAJFAV8xmCECbDB4BMWmqr2DnQR=Y_Yb2sbohy4ivvzt=JfPkKQ@mail.gmail.com> (raw)
In-Reply-To: <20240320171120.255142-2-rjarry@redhat.com>
On Wed, Mar 20, 2024 at 6:11 PM Robin Jarry <rjarry@redhat.com> wrote:
>
> * Quote graph name to avoid parsing errors when it contains a dash.
> * Use fixed margin and smaller font for a more compact layout.
> * Use sans-serif font, the default is times new roman which is not the
> best choice for a packet processing generated graph.
> * Force bold blue border and arrows for source nodes.
> * Force dark orange borders for sink nodes (nodes without next nodes).
>
> Link: https://f.jarry.cc/rte-graph-dot/before.svg
> Link: https://f.jarry.cc/rte-graph-dot/after.svg
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
Acked-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2024-06-18 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 17:11 Robin Jarry
2024-03-22 8:02 ` [EXTERNAL] " Kiran Kumar Kokkilagadda
2024-06-18 13:15 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xmCECbDB4BMWmqr2DnQR=Y_Yb2sbohy4ivvzt=JfPkKQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=rjarry@redhat.com \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).