From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B2DC4548D; Tue, 18 Jun 2024 15:16:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AB9A40E4D; Tue, 18 Jun 2024 15:16:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EBE3B40E5A for ; Tue, 18 Jun 2024 15:16:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718716566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtR4nEARLHiwI7rM7Hq2NlEEg2xCUF40L5qrIeaAzJE=; b=ML5ixGfIa8QiihC6hL5iTHs/RrK+/wZH0TYxn6I1Ayxo+uMaRpbAeFzMVhAuvA03u/2eIE REoD+59OTujg5wYuS1rgg78JT6rVjZjMIhu7l0Ub6ghlitOwtA4qmsYCp6q4HHenZjpp1f dXHEty+CWa92eZAFtwjZmoLch0fSYiE= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-cN0Qg-3PORWa0qFRBHCWuQ-1; Tue, 18 Jun 2024 09:16:03 -0400 X-MC-Unique: cN0Qg-3PORWa0qFRBHCWuQ-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ebdf6d6e0dso30779781fa.0 for ; Tue, 18 Jun 2024 06:16:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718716562; x=1719321362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rtR4nEARLHiwI7rM7Hq2NlEEg2xCUF40L5qrIeaAzJE=; b=pRva1bxkAuqmoY5L1yl8NapIOz2/fwUACo667QB88xvIBRX6zroup+Kw8VtrLm0DMS LnWgp0AdPhk8GxSbiHGnnVV0XVJ9+JtD/7Qd0izR5IsuYtB7ta8MySoYhOn+6b7uYPVr Hv5Fkytu/2R4ALcNSiA/2a1JrbSGTmphYp17ylo/G6cwyw3Tk+ZWRA1c1Pc1/hbNCdDA +ZKmvZ0Rxix8q/vmomePy1a0zis1s6rREqTjCRn12qrX3royT68Srp0xRgMCM+Z5FB/2 0FTz8pjFrvSHO1M+0sFEHo6fQlLljmkkgUrq9j6dUrElQjUw1SWlNi6kF4QcnIw92bb9 LWzA== X-Gm-Message-State: AOJu0YyZvlbAOqnUAE2IZcqf+d9QvjZq9BVhBc2W7+0wMtxWx86N1raG cvyrU4SQQc9t6lOtXEmZ+Zem0bmSXziR8PCj86UaLkFydp2Sg7e2WJyOSf51yM8/gFmE1PfyzTF JqeXWIFnma28TNWvQFHxEkiEf1Xbgep0hg2bvV4GAGLwj+eVD5H7SMZXLC/iBtWX8hXleGnTUC5 lNNtueFrGuRkbpFKo= X-Received: by 2002:a05:6512:3d08:b0:52c:910b:9c7d with SMTP id 2adb3069b0e04-52cc47fdb50mr792579e87.21.1718716561981; Tue, 18 Jun 2024 06:16:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCTdaYvRWGWAUgrsl5cvDKtW6G+Dg76NdizTVntvGaDJGnoa8Eal2MGSt/OgJ0GlkzoXXV59uPh1HyopIfjiM= X-Received: by 2002:a05:6512:3d08:b0:52c:910b:9c7d with SMTP id 2adb3069b0e04-52cc47fdb50mr792570e87.21.1718716561641; Tue, 18 Jun 2024 06:16:01 -0700 (PDT) MIME-Version: 1.0 References: <20240320171120.255142-2-rjarry@redhat.com> In-Reply-To: <20240320171120.255142-2-rjarry@redhat.com> From: David Marchand Date: Tue, 18 Jun 2024 15:15:50 +0200 Message-ID: Subject: Re: [PATCH] graph: enhance export to graphviz To: Robin Jarry Cc: dev@dpdk.org, Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 6:11=E2=80=AFPM Robin Jarry wro= te: > > * Quote graph name to avoid parsing errors when it contains a dash. > * Use fixed margin and smaller font for a more compact layout. > * Use sans-serif font, the default is times new roman which is not the > best choice for a packet processing generated graph. > * Force bold blue border and arrows for source nodes. > * Force dark orange borders for sink nodes (nodes without next nodes). > > Link: https://f.jarry.cc/rte-graph-dot/before.svg > Link: https://f.jarry.cc/rte-graph-dot/after.svg > Signed-off-by: Robin Jarry Acked-by: Kiran Kumar Kokkilagadda Applied, thanks. --=20 David Marchand