From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A482EA04B5; Sun, 25 Oct 2020 17:18:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD6202A66; Sun, 25 Oct 2020 17:18:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id DF9FB29D6 for ; Sun, 25 Oct 2020 17:18:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603642731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5yGxSNguabqSH3W3/vcSr+IXkJbASrT8Rzcn9S/ccVQ=; b=MCeNGgVS3ZotKztbV9aXHqoO2Z12BacqGF9vnRzsdQukwwiuRznOpH+jnrOcxB7khsxFWb OUJ3lcjvqFSetfFRnYtfI+9LJrIqDd3wfVXlOTY5K35Nflu8zbssZWlgJKpBQV6C0Lo7E5 J00EscgVIBVB2eBOAEeRPDZPCMLctdE= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-r0c4wGq_MzC8zOByvf-oaw-1; Sun, 25 Oct 2020 12:18:48 -0400 X-MC-Unique: r0c4wGq_MzC8zOByvf-oaw-1 Received: by mail-vk1-f198.google.com with SMTP id j129so2787314vkb.15 for ; Sun, 25 Oct 2020 09:18:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5yGxSNguabqSH3W3/vcSr+IXkJbASrT8Rzcn9S/ccVQ=; b=VpAAF9r3bmXvlm+hv4VDTZyC6EAlnG6drcrMZIvnIZM+EKzIxaAVEbkF54LI11zIyR qt7G2kHW7AJxU1L+me5JA9iBT0OIPAmRA2Zr3xuvLOFUAxxlgLZHE5xuEljD21iHH4mu Zf4ezINWmd5Hh7EEUemRbDOKyTPNS/TKv/pu4/fXPKIrF/zQEKDlrEf8pTOVOlUAYI7n pO7o8fmOX9iFcJoQa9m/6yhtCWtJAhaYS2Wrn7ffK1NGaoXZgUTCd7TaC9gIT+kNh5e3 gyOEuaCdp03IgNVpfMnCeKQuGrPuyaBn5NzrmMFymWL4IFZoNIC+t8RDJ2pyoqllOE6+ pT9A== X-Gm-Message-State: AOAM530XWL8IB9dXJbTtb4ckVpm3GdiarSadhbedSgV4xB+dzeUnK8Be h2LWOEOGg9OI2JsNz8yYt/+O+s6SwFscpOHB5zpJt7TXqVQUtPoZYWz/hOlJCRCa15nCRSP2DJO ob6Nc3Ep9McSsq2JIOHE= X-Received: by 2002:ab0:4983:: with SMTP id e3mr14444905uad.41.1603642727690; Sun, 25 Oct 2020 09:18:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqRFmNZ5RPF/hbTYwuecmeXLSIj8tjImPEHChVkJyJxw+Eena4Rc+474tfrTR+Tx3FJPY8Po/eSQeZNDrbiFQ= X-Received: by 2002:ab0:4983:: with SMTP id e3mr14444890uad.41.1603642727461; Sun, 25 Oct 2020 09:18:47 -0700 (PDT) MIME-Version: 1.0 References: <20201014100114.26596-1-huwei013@chinasoftinc.com> <20201014100114.26596-2-huwei013@chinasoftinc.com> In-Reply-To: <20201014100114.26596-2-huwei013@chinasoftinc.com> From: David Marchand Date: Sun, 25 Oct 2020 17:18:36 +0100 Message-ID: To: "Wei Hu (Xavier)" Cc: dev , "Yigit, Ferruh" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] net/hns3: support SVE Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Wei Hu, > diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build > index bf69ad4..ca0f21a 100644 > --- a/drivers/net/hns3/meson.build > +++ b/drivers/net/hns3/meson.build > @@ -31,4 +31,9 @@ deps += ['hash'] > > if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') > sources += files('hns3_rxtx_vec.c') > + if (dpdk_conf.has('RTE_MACHINE_CPUFLAG_SVE')) > + dpdk_conf.set('RTE_LIBRTE_HNS3_INC_VECTOR_SVE', 1) > + cflags = ['-DCC_SVE_SUPPORT'] > + sources += files('hns3_rxtx_vec_sve.c') > + endif > endif This patch is already merged in main, but RTE_MACHINE_CPUFLAG_* have been removed, see https://git.dpdk.org/dpdk/commit/?id=84fb33fec1 I guess SVE support is not working because of this. Please use compiler flags to check for support. If you need an example on how to do this, you can probably look at what has been done for Intel vector stuff. Besides, RTE_LIBRTE_HNS3_INC_VECTOR_SVE is not used anywhere and can be removed. -- David Marchand