From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>, Mit Matelske <mit@pt.net>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/freebsd: fix queuing duplicate eal_alarm_callbacks
Date: Thu, 19 Mar 2020 09:48:27 +0100 [thread overview]
Message-ID: <CAJFAV8xn7Rd-SFskWOojUdrzbecw2Lh-aAb=LX4OoH94uFKXBw@mail.gmail.com> (raw)
In-Reply-To: <20200316173552.GA1972@bricha3-MOBL.ger.corp.intel.com>
On Mon, Mar 16, 2020 at 6:36 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, Nov 20, 2019 at 02:10:56PM -0600, Mit Matelske wrote:
> > The source callback list grows infinitely when more than alarm
> > is queued.
> >
> > This fix recognizes that an alarm interrupt in FreeBSD should never
> > have more than one callback on its list, so if
> > rte_intr_callback_register() is called with an interrupt handle type
> > of RTE_INTR_HANDLE_ALARM, so if such an interrupt type already has a
> > non-empty list, then a new callback is not created, but the kevent
> > timer is restarted properly.
> >
> > Signed-off-by: Mit Matelske <mit@pt.net>
> >
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Missing a Fixes: line.
And probably worth backporting, so
Cc: stable@dpdk.org
--
David Marchand
next prev parent reply other threads:[~2020-03-19 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 20:10 Mit Matelske
2020-03-16 17:35 ` Bruce Richardson
2020-03-19 8:48 ` David Marchand [this message]
2020-03-25 12:53 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xn7Rd-SFskWOojUdrzbecw2Lh-aAb=LX4OoH94uFKXBw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mit@pt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).