From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6C69A0583; Thu, 19 Mar 2020 09:48:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B27B829D6; Thu, 19 Mar 2020 09:48:42 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id D0053CF3 for ; Thu, 19 Mar 2020 09:48:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584607721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D5/m+TaqRuaJw6gwQo/NVHC/lc8WROzCQOxla5q4ZMo=; b=TufdCE0HZKABT3p6lIID2WvQA171j4KCLJMRuxZnAmI3COx45ZV2Wru2VHgxro5xvMsiwW Fx4VuZ964xw4NXVAhdkQvWbw+mdosrquvxfayJQXAKvRyH7dnv05gWPcJAmUgIPD8bRaeJ jOdJaNbeUiedacmVSrIKWd3pUvoPuPQ= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-g8W5QcGNN9ezrakg1CbD1Q-1; Thu, 19 Mar 2020 04:48:39 -0400 X-MC-Unique: g8W5QcGNN9ezrakg1CbD1Q-1 Received: by mail-ua1-f70.google.com with SMTP id 42so405393uar.1 for ; Thu, 19 Mar 2020 01:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zm4tKOUEXc2HO/S/3Ss3gRUHGqh/KmM3HnCSee8xea4=; b=QuR/hb4zG7DCyiKLlNp+QBY5xtxiBBXDnEC88aLjYTqA6QPBi+t6JTYdJJP6+m40Wu 1hMEedeEqkuWjDRv9dTToPB/Rdf3LQZViuu1I4xW+NAdVOQvy/0ruNqEHkKWJm48wRCE 9WDNr529x/luiguloNvV4NsGWz5gOBgjaC1qjMiU52c0YZI68aDMjWz9pGSI4NlQtxvf bJ6JrS/8CO2gJk32ramFTCbXJRX0yBBapyDr0Nqv2rwmo/X89K5e22yjMwp3Z1wJ7szC XPqah7xHOMlc6Av8Lj1mZdTnFGRawJENWqQMWmu8XRT/5cUkVid0mGOD6dgFjhTzRTX1 LzcA== X-Gm-Message-State: ANhLgQ18T4SPQsgTD7CVtzFNK912QpzQe9nUdCTz+OzUuGb2vd3jit/8 IQIIGCUUrQL5/2HcS5ctC+SVk19tTUk4P1fU90tSQotCIDa4GCQx3wFq452tcPwky/4EdRxO+V5 rlerdhe4yF1MWSCus+Bk= X-Received: by 2002:a67:26c2:: with SMTP id m185mr1212415vsm.180.1584607718893; Thu, 19 Mar 2020 01:48:38 -0700 (PDT) X-Google-Smtp-Source: ADFU+vse5ykiIpdNblCHkcFZo9rctNSeFW5KMoIgFHynVGJCQu0nUszSy9+VinLMmaYxu9NWwuqG53zrjTwsiqzsZTA= X-Received: by 2002:a67:26c2:: with SMTP id m185mr1212402vsm.180.1584607718581; Thu, 19 Mar 2020 01:48:38 -0700 (PDT) MIME-Version: 1.0 References: <20191120201056.63818-1-mit@pt.net> <20200316173552.GA1972@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200316173552.GA1972@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 19 Mar 2020 09:48:27 +0100 Message-ID: To: Bruce Richardson , Mit Matelske Cc: dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/freebsd: fix queuing duplicate eal_alarm_callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 16, 2020 at 6:36 PM Bruce Richardson wrote: > > On Wed, Nov 20, 2019 at 02:10:56PM -0600, Mit Matelske wrote: > > The source callback list grows infinitely when more than alarm > > is queued. > > > > This fix recognizes that an alarm interrupt in FreeBSD should never > > have more than one callback on its list, so if > > rte_intr_callback_register() is called with an interrupt handle type > > of RTE_INTR_HANDLE_ALARM, so if such an interrupt type already has a > > non-empty list, then a new callback is not created, but the kevent > > timer is restarted properly. > > > > Signed-off-by: Mit Matelske > > > Acked-by: Bruce Richardson > Missing a Fixes: line. And probably worth backporting, so Cc: stable@dpdk.org --=20 David Marchand