From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17D3DA054A; Tue, 25 Oct 2022 13:54:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0289E42BF6; Tue, 25 Oct 2022 13:54:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AD568427FF for ; Tue, 25 Oct 2022 13:54:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666698858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g83su7cIjTleeA80yYNLwI8ngD0rjmppmmKGWx1gslY=; b=BNZJIAxhyz4xzSM4i6tkPgxZuYrmt3UAtxDas8ON2HOe0CalBns8DoQQnwyxxyLWfzjJSo kDQhuHHHwUCZ1NXg2k2mDC+6rfgRtlKTTbYuwGHgg2guIlBjRAQSY44RO0mzoifF/Nk/gG pimTRrN9bRapcy6yfgGUC2BM6x4IbDQ= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-644-K821xsL_PWWo9TsG_MTg0A-1; Tue, 25 Oct 2022 07:54:17 -0400 X-MC-Unique: K821xsL_PWWo9TsG_MTg0A-1 Received: by mail-pj1-f69.google.com with SMTP id m2-20020a17090a730200b0021020cce6adso10630855pjk.3 for ; Tue, 25 Oct 2022 04:54:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g83su7cIjTleeA80yYNLwI8ngD0rjmppmmKGWx1gslY=; b=pzIAxpPKgq24zYum/ovXBbYIPL+DBtgrQE1FLRWHwexEY9fiBQyzzZdmQ4xohh4M+i N+2TkWdpFU94C54acskVzJxhCuqiLsig4HfJI5ftOXW+Zwyg1Oqf/D43vAS+LSCVR+DT PybGr4d3hqJeJPbWXRQN59F0Uw77PpfEnHhITH+sNth+9y53CTKXlmN9WpOQoyOhTmct qoAd/L2cxtzywcsXSGPL/59hMPRlVG2OOI19M6hwU1ywS4ToQXuTFDCslmMm5uVaS1z8 lsKBZWOZmNDaF7wB9mDzQ7tTKs4+FKoXmD2MkZCfJp0MF95IXhuSoQ7EEWbRsOqjZW2z wgNw== X-Gm-Message-State: ACrzQf2JZOyLoen61wdyP+SLIUAecNBXxdltdW+Uf+Y0+VT5H/xbVSol dAiwMOfn2JJqOeqwCXEiKZ5yUnI1PRzxlrimqTnn7bK/au2iZ8x/61xyWZ2LCkkWilPXr6o6Xop UThRCCZITLo5aikXBI3Q= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr81785476pjb.39.1666698856023; Tue, 25 Oct 2022 04:54:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4CjMmjf+WX2pqJEMfs7/2AYUOFIOoKAsexLNbeI8rWitCSk2RZAKmOiDWg43HUJCWU7S20C3e6dpDanWy2uKg= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr81785444pjb.39.1666698855730; Tue, 25 Oct 2022 04:54:15 -0700 (PDT) MIME-Version: 1.0 References: <20220912160157.3642968-2-mpiszczek@ddn.com> <20221017154507.934995-1-mpiszczek@ddn.com> <20221017154507.934995-2-mpiszczek@ddn.com> In-Reply-To: <20221017154507.934995-2-mpiszczek@ddn.com> From: David Marchand Date: Tue, 25 Oct 2022 13:54:04 +0200 Message-ID: Subject: Re: [PATCH v6] pci: read amd iommu virtual address width To: Michael Piszczek Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 24, 2022 at 5:35 PM Michael Piszczek wrote: > > Add code to read the virtual address width for AMD processors. > Updated pci_device_iommu_support_va() to use glob to find iommu > capability files. > > Signed-off-by: Michael Piszczek Please have a look at the ci. Unit tests are failing with this patch because the default is changed from VA to PA. A quick way to reproduce is to run vdev unit tests as a normal user in no huge mode. Before change: $ DPDK_TEST=vdev_autotest ./build-gcc/app/test/dpdk-test --no-huge -m 2048 --log-level=*:debug ... EAL: Bus vdev wants IOVA as 'DC' EAL: Bus pci wants IOVA as 'DC' EAL: Buses did not request a specific IOVA mode. EAL: Physical addresses are unavailable, selecting IOVA as VA mode. EAL: Selected IOVA mode 'VA' After change: $ DPDK_TEST=vdev_autotest ./build-gcc/app/test/dpdk-test --no-huge -m 2048 --log-level=*:debug ... EAL: Bus vdev wants IOVA as 'DC' EAL: Bus pci wants IOVA as 'PA' EAL: FATAL: Cannot use IOVA as 'PA' since physical addresses are not available EAL: Cannot use IOVA as 'PA' since physical addresses are not available -- David Marchand