From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C96A046B for ; Thu, 25 Jul 2019 10:42:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A90231C2AC; Thu, 25 Jul 2019 10:42:44 +0200 (CEST) Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 1BD7F1C2A8 for ; Thu, 25 Jul 2019 10:42:43 +0200 (CEST) Received: by mail-ua1-f68.google.com with SMTP id v18so19532380uad.12 for ; Thu, 25 Jul 2019 01:42:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JU0VbboXEAtluLWJqcgJwPfWNLAaitXW5kDQSsLyfFg=; b=FGlPT4b79yBculHytDKvVsZGJ7cBt4Y0FrG+bVTHg06yeRqdqE4gq47mJ6TdGwTfw8 vk6qkv/LLxLpXAcooGBKy6FMtJZqZHSdmX+cfd4UWamd0kh857Dz2eah0EEuaqaC97uR tLA6+UVZxzpj2zm+IyfA2GLZf4xJ2+LE1ToDpkWena7/N144vdzU7m8dway6n6YDw2eK ExfCwjWDJFHX28TW2bFGsrJQPW2EhqceKdEdyaDFR0M25bDR42OP++CLuJjjq/pgly63 rti4DUk51OdWNO8ED1zIf0/iLkuIA1xPbotueoS09xdWpjNNRDEz3PJTrBZTM4lpsfOb UlDw== X-Gm-Message-State: APjAAAXE2hUt3JUq0wjBqaqhwfTBzUD0NESUZqXwdnlNbQSYAhbrZE6f A4shI+VcgOj9oxLfkzpEiPH4k+kQKINJ3LZHLbd88Q== X-Google-Smtp-Source: APXvYqxd2mCMRfXmCwSz++HKHz7TTR3sn/v3FZDJDwY0hkoo2/5yGGMDxUDAJBbcCiE2hvHnaL+EESgc7tWxrmrkJj4= X-Received: by 2002:ab0:168a:: with SMTP id e10mr8852897uaf.87.1564044162395; Thu, 25 Jul 2019 01:42:42 -0700 (PDT) MIME-Version: 1.0 References: <20190724152059.17859-1-sean.morrissey@intel.com> <9665256.xY3FNFdC9b@xps> <1932425.85ze7CrQjK@xps> In-Reply-To: From: David Marchand Date: Thu, 25 Jul 2019 10:42:31 +0200 Message-ID: To: "Morrissey, Sean" Cc: Thomas Monjalon , "dev@dpdk.org" , "Laatz, Kevin" , Gaetan Rivet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 25, 2019 at 10:38 AM Morrissey, Sean wrote: > > Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" > > 24/07/2019 18:28, Morrissey, Sean: > > > > Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" > > > > 24/07/2019 17:20, Sean Morrissey: > > > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > > > > > Reverting this patch as it currently breaks the initialization of > > > telemetry, more investigation is ongoing to fix the issue for the > > > printed error message for unrecognized argument. > > > > > > Signed-off-by: Sean Morrissey > > > > It's very disapointing. > > Did you or the reviewer tested the previous patch? > > > > The reporter of the bug tested this and verified functionality and clos= ed the internal bug. > > So the reverted commit is supposed to work? > I won't apply this revert until I fully understand what happens. > > The patch that I sent up was to remove an "unrecognized option telemetry"= warning message, which the patch removed and was tested to ensure the mes= sage was removed. Further testing, after the patch was sent up, revealed th= at the unix domain socket, which is required by telemetry consumers, was no= longer being created, rendering the telemetry functionality non-functional= . > On further investigation, the full fix involves a change in the EAL comma= nd line parameter handling, which is probably too risky for RC3. > This revert will allow telemetry to function again, but with the erroneou= s message still in place. > We will aim to fix in the next release. Might be good to look and revisit the rte_option api. > -------------------------------------------------------------- > Intel Research and Development Ireland Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Number: 308263 > > > This e-mail and any attachments may contain confidential material for the= sole > use of the intended recipient(s). Any review or distribution by others is > strictly prohibited. If you are not the intended recipient, please contac= t the > sender and delete all copies. > Can you contact your IT and get this footer removed ? Thanks. --=20 David Marchand