From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 70CBBA0487
	for <public@inbox.dpdk.org>; Wed,  3 Jul 2019 09:03:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A9444326D;
	Wed,  3 Jul 2019 09:03:12 +0200 (CEST)
Received: from mail-io1-f67.google.com (mail-io1-f67.google.com
 [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 53345A3
 for <dev@dpdk.org>; Wed,  3 Jul 2019 09:03:11 +0200 (CEST)
Received: by mail-io1-f67.google.com with SMTP id r185so2295634iod.6
 for <dev@dpdk.org>; Wed, 03 Jul 2019 00:03:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=7rdBHt3pHBZ1qp8mn/BWO3SkxJaOgFPMTyELVvEd91E=;
 b=Pps1i4b+d3TaoFB0Z5ZsS3jz88QM2d6Pr0JUCVlTixDI0+Sln7m7djdtvsn0LC0GuP
 v2IIBPhZyLpO+yVqlZVUyeZFZpIf2iL54Kc63ictpXFFAIyhKBnzixbT+HBPAigkRJ3y
 UeiLO8KGnGpUV+qGmMoe1xoACcw8wpXdEfwUH37bpfRiafKGNgDY7VBltrnPu3cCyARc
 +qkJ8MC2Ll0wArU6yRbvejL+pdTzoEtRpYnJHkV5oseY9R/tD1dlDDa26tkbf3tIsVuu
 ijLBMUY17D9Xyiz9iagJyMUCXgnOacWzaPW8ih3FvFcaLYNZOt3c+B3gxw61tXUP6uBC
 SK8Q==
X-Gm-Message-State: APjAAAXcVTZzSF5PywQxU+rcmttd24nSF2qAF2fUK793wUvZKBGAvC/z
 PY8p68UgwYN0I6IDaIYNPbPKeoe/CG5LmB2aMRr7bziz
X-Google-Smtp-Source: APXvYqxHjbmAQOnfh6CDJ5GgoYRXR9Oz6XVhGRy+5WQXRd4xLY57JJKFlUzA4VyYhKrHT9ghxxxSH3pTzt7iFxZRqzk=
X-Received: by 2002:a6b:e203:: with SMTP id z3mr5588047ioc.23.1562137390576;
 Wed, 03 Jul 2019 00:03:10 -0700 (PDT)
MIME-Version: 1.0
References: <20190703054508.22824-1-tiwei.bie@intel.com>
In-Reply-To: <20190703054508.22824-1-tiwei.bie@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 3 Jul 2019 09:02:59 +0200
Message-ID: <CAJFAV8xnN5nDjDn+PngYHheP0un2tPS+RGx_AX36cMUCYGXmOg@mail.gmail.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private
 value in kernel source
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello,

On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie <tiwei.bie@intel.com> wrote:

> The value 40 used in VFIO_GET_REGION_ADDR() is a private value
> (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It
> is not part of VFIO API, and we should not depend on it.
>
> [1]
> https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/pci/vfio_pci_private.h#L19
>
>
I did not follow linux kernel changes, is there something that would change
this offset?
It looks like a cleanup (did not look into the details yet), do we need
this now?


-- 
David Marchand