From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87DA0A32A2 for ; Fri, 25 Oct 2019 11:37:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4232E1C241; Fri, 25 Oct 2019 11:37:00 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id B959C1C232 for ; Fri, 25 Oct 2019 11:36:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571996218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dr22a4mtdGsDg0mRx6bH05WdnVFPA+P1INBbssgoVNI=; b=Im65Tge++rp4YehIGcqJ7RBhtmH8y9pxE0MCy/tvxRwBQaDHRexur/o3utWmWf6CmZDcEq bA+GWNJ1ikJUShkk3NBdUnhHqOTGOceglCmpvoZgXOcca3tEjpjKgjGqioc+Y19znF14R1 /fRUO/O5zzek8LSX54/3THdZ0Pbr5Ps= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-fn7oka1bMWuC6ornpgZpvA-1; Fri, 25 Oct 2019 05:36:57 -0400 Received: by mail-vk1-f200.google.com with SMTP id v71so546749vkd.16 for ; Fri, 25 Oct 2019 02:36:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KoGfvmB+uyu9HHb96hYTMZHXckjnbHIh7RywL/ZzVD4=; b=KdjHyte6mWIojuSFHvwKNkxCmtDEoFuAnJIt8CeU9yRDed1iKf15Rcb+JO/vkq2F4R Ppekoxei5cp7oRbeemowERBFQ8KjQ0oMTOOWFU2be9NMmTXLfxddsNG27Asz1fcBpnB2 wTX+hgB1cGyV+/JMEJrbY/Wz8c2Qxo7lexstHboNegYBppGnePEFjimT6/VEAsUS5oFU JqSMfPYYRXntidM4KrJzoSRlkD+r4R3/6ET5swoYaZvxFpM2V7KxZwV/gR0wp10ubai1 qZl2ZkH2zcFENyq6hsuDS7ltRQD1Y+YaL3eWdb8cs6dc3ohgKiWkDS/8AQh0AF6UJ+Tm rPkw== X-Gm-Message-State: APjAAAUSU2JUYHVcIVwF2sd1xk3R/Detqmwupc6Og3wk2s5SbeuN5zqT bCmah+hBefXDsYwuyEowqC1bUGLzoPks3lilUiE1ZxRtH9IMdjym4TKeV+yqmfEIR9dxqH9bN3M rj4buA7kwbKcPWrgtqW0= X-Received: by 2002:ab0:189a:: with SMTP id t26mr1085892uag.87.1571996216388; Fri, 25 Oct 2019 02:36:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxyOApRdO077NsfNaLW8A9/q5x4ul2urZyOFy9pbdW1Iu4W6xIHpszLr6AzMa8BI7+gjEwHU/uy6sIjvW02Elc= X-Received: by 2002:ab0:189a:: with SMTP id t26mr1085882uag.87.1571996216128; Fri, 25 Oct 2019 02:36:56 -0700 (PDT) MIME-Version: 1.0 References: <26384fad6f9afcba9d3311d1bf73e76f4577225d.1563276298.git.anatoly.burakov@intel.com> <41c41b7a73cea7f574bc709e1fb1cd4eed4c72e3.1571930271.git.anatoly.burakov@intel.com> In-Reply-To: From: David Marchand Date: Fri, 25 Oct 2019 11:36:45 +0200 Message-ID: To: Anatoly Burakov Cc: dev , Bruce Richardson , Thomas Monjalon X-MC-Unique: fn7oka1bMWuC6ornpgZpvA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: use define instead of raw flag name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 24, 2019 at 8:59 PM David Marchand wrote: > > On Thu, Oct 24, 2019 at 5:18 PM Anatoly Burakov > wrote: > > > > We are using '--base-virtaddr' in a few places. We have a define for th= at, > > so use it instead. > > > > Signed-off-by: Anatoly Burakov > > diff --git a/lib/librte_eal/freebsd/eal/eal_memory.c b/lib/librte_eal/f= reebsd/eal/eal_memory.c > > index cd31827c2b..a637127d5e 100644 > > --- a/lib/librte_eal/freebsd/eal/eal_memory.c > > +++ b/lib/librte_eal/freebsd/eal/eal_memory.c > > @@ -14,6 +14,8 @@ > > #include > > #include > > #include > > + > > +#include "eal_options.h" > > #include "eal_private.h" > > #include "eal_internal_cfg.h" > > #include "eal_filesystem.h" Hit build issue on FreeBSD: In file included from ../lib/librte_eal/freebsd/eal/eal_memory.c:18:0: ../lib/librte_eal/common/eal_options.h:79:15: error: 'struct internal_config' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] struct internal_config *conf); ^~~~~~~~~~~~~~~ Fixed order of header inclusion. Applied, thanks. -- David Marchand