From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29508A0503; Thu, 19 May 2022 16:54:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA41F40222; Thu, 19 May 2022 16:54:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 46C6840156 for ; Thu, 19 May 2022 16:54:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652972040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=esGxvb1FH2eOvKMXyzROj43ML8L8kyifM4A4sqJnMKk=; b=RttdKwnndMWWDvm8ldyTVdDNINWQuTonjsTCV6WV/gAhm5BYqRb+zSBU1a9GDY7VeyNQBk 0jIjg+Ipxrs+Eim+wHiw8RHW7X13Jf2hoSVLHeTXv4MK80Q+MRP7qFyVMEcD9IvCbfkU28 HMTzpus6phxxPMTu755xf75l+4NH5Bs= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-279-mPeQn_1HMVyDw4Y37qzRzQ-1; Thu, 19 May 2022 10:53:57 -0400 X-MC-Unique: mPeQn_1HMVyDw4Y37qzRzQ-1 Received: by mail-lf1-f71.google.com with SMTP id k3-20020a05651239c300b00477b22d54c3so2745691lfu.20 for ; Thu, 19 May 2022 07:53:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=esGxvb1FH2eOvKMXyzROj43ML8L8kyifM4A4sqJnMKk=; b=QeTg4lSfsQZSB/KbhVLc6cJFNysFF76/nH4IQoOlNAhAsfa4qQ4+Fg8HvPrGORdJwe Pc+/sKXeH4ePJTyQXNSdGtfjlbYMo3GF90e9xdjhUFQeq242n+yZc0HkVnlBZk5iHFBA VEtrAOAsuWaSJkTXEDqwyKG6EX05CFRcGJ4RzLEE9iEbzFXrV1UWyWw4O2VJATynup1d +gma8WdisCGzlaPSCHLOTXkRTz4zxbbDsv5vgvy3gPqRwrYnaXC+lP+EN/0S86/l1/zA 4ySNA6r55Vyw+lpoZRz7zghV2n3Fl+kPEXjDNwQB1bn4XmORfGBCdR4WNV4LCJjD0+Bf OVmQ== X-Gm-Message-State: AOAM532eFj712SLF7ruXIlb5RbRHFxjYX0DhrpVDL96fDdjKKsSAkqij ITWa+TB24Jnr2zHa8HROhxjR5soEqPzXnL0Zm9qk8/luKszhAVZIGKrEoIH6qCda436u3kK07ZG Xj0MJbFkrqELWmu3qDu0= X-Received: by 2002:a05:6512:3183:b0:473:dffc:18ac with SMTP id i3-20020a056512318300b00473dffc18acmr3518571lfe.217.1652972036144; Thu, 19 May 2022 07:53:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMkX1BqvS9kxL8em2UsM/BkcqT08rEaRe7MFF3CWYKVueD7obp7UJLEPtJ3N3HjsqqGZ4xd240eKJBMS8f5pw= X-Received: by 2002:a05:6512:3183:b0:473:dffc:18ac with SMTP id i3-20020a056512318300b00473dffc18acmr3518554lfe.217.1652972035986; Thu, 19 May 2022 07:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20220510115844.458009-1-kda@semihalf.com> <20220511145650.742535-1-kda@semihalf.com> In-Reply-To: <20220511145650.742535-1-kda@semihalf.com> From: David Marchand Date: Thu, 19 May 2022 16:53:44 +0200 Message-ID: Subject: Re: [PATCH v2 1/1] examples/l3fwd: fix scalar LPM compilation To: Stanislaw Kardach Cc: dev , Frank Zhao , Sam Grove , Marcin Wojtas , upstream@semihalf.com, Pavan Nikhilesh , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Vladimir Medvedkin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 11, 2022 at 4:57 PM Stanislaw Kardach wrote: > > The lpm_process_event_pkt() can either process a packet using an > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) > path or a scalar one. The choice is however done using an ifdef > pre-processor macro. Because of that the scalar version was apparently > not widely excersized/compiled. > Due to some copy/paste errors, the scalar logic in > lpm_process_event_pkt() retained a "continue" statement where it should > utilize rfc1812_process() and return the port/BAD_PORT. > > Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop") > Cc: pbhagavatula@marvell.com > > Signed-off-by: Stanislaw Kardach Reviewed-by: David Marchand -- David Marchand