From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C282A0032; Thu, 1 Sep 2022 10:22:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6406E40684; Thu, 1 Sep 2022 10:22:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BE15940395 for ; Thu, 1 Sep 2022 10:22:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662020547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ykXhO+25DJX8+tLimQHim4WVplcixLogQtuO+yMrzCM=; b=g8+IRqIOVlHa99TDnVEqbP/cpeT6g/84j9brlbD0JOET70TZgiaG9sOFrVNJ573grLTu+V 0/OFQfoSpj3FIP1R0O4aJ3EJSLzf0LDMRF1RHLldj28J6ErOHfMX2On8YUyVY3P719+uSi KB8BUyNlsr1Ns/03H/nq2giFlz8HCWI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-104-MAUosGOfPGO3SBdSEghkDA-1; Thu, 01 Sep 2022 04:22:24 -0400 X-MC-Unique: MAUosGOfPGO3SBdSEghkDA-1 Received: by mail-lj1-f199.google.com with SMTP id f10-20020a2e9e8a000000b00261af150cf0so4991003ljk.13 for ; Thu, 01 Sep 2022 01:22:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=ykXhO+25DJX8+tLimQHim4WVplcixLogQtuO+yMrzCM=; b=fLN5THL669yO5/ZBaqfC89eUJk8PTc31gXaA1NvGFMIx1dkzcVoGbBWe+f7L/k24Rz oAUdIjn4egzvrWl2Iv2BMyhkoSxytHXRbcNdGBLe16j5txo38LvKHh+YabQIUwXOls6Q pTXeNpBzxAQJhJFC7LYjb1WZ0Uz0/e+b48U1taaw51f019h4Lb4FgizWhRmZgvLKIKdc a5OVK9ojEn8vcm2FIs5xyXDVHazMRVa12uw55m+0RC2P9tLnKpuMM0mzhbfRP+H5zBuB xAxZi8Ikvp5VXXOccU5XyjCVH2L5r7knFOZq59TK4R8XYEGie+xokb6q8wBv+g1GA142 O+mg== X-Gm-Message-State: ACgBeo0OBE/RQ4t+VIFxve+znDtXzn7BjmKgSfoDose6SHHuCBC4aGwq 4QhjHTamDO1K+Kp8KO8AJLxAPJapWmrM5h2c/2C/vO7nPseVjKSkwBojcNzYlf/6L23d2RYgvD+ 84SBHEXA30ChgUGWZ6m8= X-Received: by 2002:a19:5f45:0:b0:492:df3d:d678 with SMTP id a5-20020a195f45000000b00492df3dd678mr11273419lfj.217.1662020542836; Thu, 01 Sep 2022 01:22:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR5R0Hg1/BErlOk+q6sEpvLADXyeXcbH1eTpi157rDFMw/6dgIAVHO1jlatl0q099s7GexTRsNBnCgzplsa5pk0= X-Received: by 2002:a19:5f45:0:b0:492:df3d:d678 with SMTP id a5-20020a195f45000000b00492df3dd678mr11273406lfj.217.1662020542575; Thu, 01 Sep 2022 01:22:22 -0700 (PDT) MIME-Version: 1.0 References: <20220829081436.29945-1-iotg.dpdk.ref.app@intel.com> In-Reply-To: From: David Marchand Date: Thu, 1 Sep 2022 10:22:10 +0200 Message-ID: Subject: Re: [PATCH] IGC: Remove I225_I_PHY_ID checking To: "Mah, Yock Gen" , "Zhang, Qi Z" Cc: IOTG DPDK Ref App , "dev@dpdk.org" , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 1, 2022 at 10:08 AM Mah, Yock Gen wrot= e: > > >-----Original Message----- > >From: Zhang, Qi Z > >Sent: Tuesday, 30 August, 2022 7:17 PM > >To: IOTG DPDK Ref App ; dev@dpdk.org > >Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking > > > -----Original Message----- > > From: iotg.dpdk.ref.app@intel.com > > Sent: Monday, August 29, 2022 4:15 PM > > To: dev@dpdk.org > > Subject: [PATCH] IGC: Remove I225_I_PHY_ID checking > > > > From: NSWE SWS DPDK Dev > > > > i225 devices have only one PHY vendor. There is unnecessary to check > > _I_PHY_ID during the link establishment and auto-negotiation process, > > the checking also caused devices like i225-IT failed. This patch is to > > remove the mentioned unnecessary checking. > > > > Cc: stable@dpdk.org > > Signed-off-by: NSWE SWS DPDK Dev > > >Is this the expected author name? > Yes, this is expected author name, the PDL email contain all developers w= orking on the patch for better support and response. This is not acceptable. https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body It is clearly stated that: """ The signoff must be a real name and not an alias or nickname. More than one signoff is allowed. """ And all developers involved in the making of a patch must follow the Developer=E2=80=99s Certificate of Origin. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#deve= loper-s-certificate-of-origin-1-1 In its current form, this patch cannot be merged in the DPDK project. Besides, please register to the @dev mailing list. --=20 David Marchand