From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92ABD43B04; Tue, 13 Feb 2024 12:10:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4632A4029C; Tue, 13 Feb 2024 12:10:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 093AC4027B for ; Tue, 13 Feb 2024 12:10:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707822646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W77vqRnY+0t5qDr6NgkEG9E403Vqcl+OU2mv0/uvKrc=; b=Uqz5H+q0vZqDl0U3t1QBY3gdZyL+9aSu3Rns/RL+7vMyJZoxxl8Opu6anCmspulVxuMldW ngoXGlaaugWZkBmopIrcjfd52JpFAlL+35955/5g3wWkasrs1eJMDic+DP5JD097lbcJqn QjGD4du/0uI527gTfcSecGosROdDqec= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-Bpi7DXWhMj285q1a6B7WYA-1; Tue, 13 Feb 2024 06:10:45 -0500 X-MC-Unique: Bpi7DXWhMj285q1a6B7WYA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5117bac8b0cso3132187e87.3 for ; Tue, 13 Feb 2024 03:10:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707822644; x=1708427444; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W77vqRnY+0t5qDr6NgkEG9E403Vqcl+OU2mv0/uvKrc=; b=ZBOzPAmlVnj6VzmfXehGikM1HzMuLLhm4NquoQkX3VhwCdOGyZVYGA9JCHNnJWWcOM lrXZ/zNyztU0efXBtY5pjqohOORJto6gbPm4EdvGse2G/KrC4iuj4YhHCx6fxVquoVuv BrhDxETNlhxtTo0JI2fAH7gWdOQoMloUNim+3TIJIurUu2I+2sX68PcuAo81NxwhCYvQ OxHBIPPScFB0oLkbu9aT+OYyF2xyHHuJfxasoyQENNRn64wsD6Eaqub8FHAuzkYp47xh hmKrVY48qGC/u0DP5YnN/mkjy7GWG3bv+BApFfaOZXYgp68zPMVcAMlkcFVnAgM6OVeJ ggRQ== X-Gm-Message-State: AOJu0Ywo3a3SXcxjo/takeOEpLHztKJ7vRWaSKG9flbonNzbmhk9iQj+ Zpizt99BQqLjZl9H0LPA1zJEVo3rl2ZY1TDu6d4tECYhnY7EnYEaauEQbUswhYTQhzt7HG4Mn90 GtyK5OuKsGk71OAFEni62mRxu/YtUC6pcESpk04XjxNC7m9A8tF2M6HZmujBw950/VkBhgA+8xs GcYkKTC3MqxQiWdcg= X-Received: by 2002:a19:f60e:0:b0:511:8d49:4b4f with SMTP id x14-20020a19f60e000000b005118d494b4fmr3408972lfe.6.1707822643905; Tue, 13 Feb 2024 03:10:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcBXAsqEw4RWwHaiZaR0phO4WcW//n0i477EJ27E9zH165hPJOV36/hN69ub/fbol5s6/9CE93fnPnWNT8tcI= X-Received: by 2002:a19:f60e:0:b0:511:8d49:4b4f with SMTP id x14-20020a19f60e000000b005118d494b4fmr3408963lfe.6.1707822643612; Tue, 13 Feb 2024 03:10:43 -0800 (PST) MIME-Version: 1.0 References: <1706660329-1752-1-git-send-email-roretzla@linux.microsoft.com> <20240212175603.GA1977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: From: David Marchand Date: Tue, 13 Feb 2024 12:10:32 +0100 Message-ID: Subject: Re: [PATCH] eal: remove unnecessary use of statement expression To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 13, 2024 at 11:41=E2=80=AFAM David Marchand wrote: > > On Mon, Feb 12, 2024 at 6:56=E2=80=AFPM Tyler Retzlaff > wrote: > > > > ping > > > > could relevant maintainers take a look? > > This change comes from the old commit 5f2c68a710e1 ("lib: work around > braced-groups within expressions"). > I suspect this change breaks application compiling with pedantic, > without setting a C standard >=3D C11. Oh, I get it now. I was confused because of the other series 30308. I'll merge this first patch. --=20 David Marchand