From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1853443A35; Thu, 1 Feb 2024 11:33:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05A7542DFA; Thu, 1 Feb 2024 11:33:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 92BB642DF9 for ; Thu, 1 Feb 2024 11:33:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706783625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JBjPFZqEhAyMXbNejQ/cjx/AvW97GFac5IzDt72iseo=; b=UaVV5yiD1JI/7/Z+xiERMT9L2I87WZCbZosQOFvpYWfEHvS28Wvb/eV1t+JsU4tPTiDQ92 4QIdOpbAVS9HY8H04S1uI6N9IZCOIu7x8NgeIbHoJf/7tZcPF+x52MvbQ7AoUetzckFCst FH+Rs+gTrSaRWunUx5PHDVRkkjZnhfI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-oGL6AIVkPsaHfwGc_XDn9A-1; Thu, 01 Feb 2024 05:33:43 -0500 X-MC-Unique: oGL6AIVkPsaHfwGc_XDn9A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50e91f9d422so836519e87.2 for ; Thu, 01 Feb 2024 02:33:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706783622; x=1707388422; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JBjPFZqEhAyMXbNejQ/cjx/AvW97GFac5IzDt72iseo=; b=piGnZRZ6K8R1aX15wqdbSOSeOW5bDHhlJz3Ksw6CUSn1lKarP1iocO8YiOWjeVoWwR VLqUkS0ns5DY5Py7LRmutRJneWS5Oqa7eOw29hv2Wsc/Bb0ZcG8TuNMBAYbYYQqR9/zZ 3yghobPBMDRbdObC1M87pkWi0O6pwXEqf/uhrXA5Bgx4weJc/Ut28zzwZkO/VDCyKwP/ HKDVo/CP0F40xK73o+t1BRdtxOMiqSXEAX5xYCFFzoU4XWgN1c1c9PBJHyF/e98ghWjl PaG56q88wLMeYDptUdz+lAkji2+irHGuSj1WCl4rOat9czHvHLJj/ABYfKkpIjFo16/7 VjJQ== X-Gm-Message-State: AOJu0YwUKQvGeQUb1k+ocFANnXC9fR5lbV4zzHlsz5LcqCYhUxBBH0fd QFI4G42LFYqVr9p2LGbRjX/hyjqQ7ZqiZO2ca64nIZ6Nx4Uz8WULACftZw+H/u34krE40mXHQt2 JcvorHtaPkE0QTf94Ibhd9pKSxOZzJNVQIfGgkvIB2Bt2srQSpicKnLe0whwUaDfNiaxz3G76n+ u+z5a6skcrQYH31t0= X-Received: by 2002:a05:6512:2c8f:b0:511:31d4:198c with SMTP id dw15-20020a0565122c8f00b0051131d4198cmr327763lfb.39.1706783622412; Thu, 01 Feb 2024 02:33:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4m14uh/UcdlJL+uAirPN4dkv65ybjyWKLLx3BA6gxJfDfHmTrJ/ZpRTI0uqJjlhX8K8mMsWY8VraRu7s4TSA= X-Received: by 2002:a05:6512:2c8f:b0:511:31d4:198c with SMTP id dw15-20020a0565122c8f00b0051131d4198cmr327755lfb.39.1706783622141; Thu, 01 Feb 2024 02:33:42 -0800 (PST) MIME-Version: 1.0 References: <20231214113021.517622-1-bruce.richardson@intel.com> <20231214170303.GA22258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20231214170303.GA22258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 1 Feb 2024 11:33:30 +0100 Message-ID: Subject: Re: [PATCH] app/test: remove ifdefs for cmdline library To: Bruce Richardson Cc: dev@dpdk.org, Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 14, 2023 at 6:03=E2=80=AFPM Tyler Retzlaff wrote: > > On Thu, Dec 14, 2023 at 11:30:21AM +0000, Bruce Richardson wrote: > > The DPDK unit test binary relies on cmdline library and cannot do > > anything without it being present. As it's a mandatory dependency we ca= n > > remove the ifdefs for it from main.c > > > > Signed-off-by: Bruce Richardson > Acked-by: Tyler Retzlaff Applied, thanks. --=20 David Marchand