From: David Marchand <david.marchand@redhat.com>
To: Li Feng <fengli@smartx.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>, Kyle Zhang <kyle@smartx.com>,
Feng Li <lifeng1519@gmail.com>,
fanyang@smartx.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] eal: use madvise to exclude unmapped memory from being dumped
Date: Fri, 24 Apr 2020 19:33:13 +0200 [thread overview]
Message-ID: <CAJFAV8xoqjthdu83BzhCrO4r6WzM2qqVh9t+tshoisDAeXoj1w@mail.gmail.com> (raw)
In-Reply-To: <20200424131905.18315-1-fengli@smartx.com>
On Fri, Apr 24, 2020 at 3:19 PM Li Feng <fengli@smartx.com> wrote:
>
> Currently, even though memory is mapped with PROT_NONE, this does not
> cause it to be excluded from core dumps. This is counter-productive,
> because in a lot of cases, this memory will go unused (e.g. when the
> memory subsystem preallocates VA space but hasn't yet mapped physical
> pages into it).
>
> Use `madvise()` call with MADV_DONTDUMP parameter to exclude the
> unmapped memory from being dumped.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-04-24 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:50 [dpdk-dev] [PATCH v2] " Li Feng
2020-04-24 11:23 ` Burakov, Anatoly
2020-04-24 11:36 ` Bruce Richardson
2020-04-24 11:46 ` Burakov, Anatoly
2020-04-24 12:37 ` Li Feng
2020-04-24 12:39 ` [dpdk-dev] [PATCH v4] " Li Feng
2020-04-24 12:53 ` [dpdk-dev] [PATCH v5] " Li Feng
2020-04-24 13:02 ` Bruce Richardson
2020-04-24 13:19 ` [dpdk-dev] [PATCH v6] " Li Feng
2020-04-24 15:20 ` Burakov, Anatoly
2020-04-24 17:33 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xoqjthdu83BzhCrO4r6WzM2qqVh9t+tshoisDAeXoj1w@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fanyang@smartx.com \
--cc=fengli@smartx.com \
--cc=kyle@smartx.com \
--cc=lifeng1519@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).