From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48408A0A04; Fri, 15 Jan 2021 16:24:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 064BE14113F; Fri, 15 Jan 2021 16:24:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 4C98D14113E for ; Fri, 15 Jan 2021 16:24:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610724275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LN/SRBgItaLQDlp/nFNgZUxAln4OYgQu07wNvkkRaLg=; b=BcSQ/p+8Rqy5W4ktWK/3aFLPdVUEnXtMh396wB0uvxROFi4ZNy8wuOohlcyT3UsipnNtO9 Sz/UqnaSr+esab8fQQI7py3qJx1RXUjcDLYwSK1FrrnwLlBR6b0z0vfr+fecruI6ayi7me XIXr+0HiPXBaf9hBT3ytZwK6UaDM39Q= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-XnkFW-BBMOa_Hlw8bYVisQ-1; Fri, 15 Jan 2021 10:24:33 -0500 X-MC-Unique: XnkFW-BBMOa_Hlw8bYVisQ-1 Received: by mail-vs1-f71.google.com with SMTP id x16so1614126vsx.6 for ; Fri, 15 Jan 2021 07:24:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LN/SRBgItaLQDlp/nFNgZUxAln4OYgQu07wNvkkRaLg=; b=kvUJ5QJEq66isSbwSFioNkimbMM/gdTkzJ+66Ju5B7Pvv3i+BIchg+OViDVsuiWhOU UDBZdXo552tNyE7ziRDgIIpYBh9qbLHm5Fbj38j0YcX5IvslJuqjOzmwFkUxlBgteDfN ITfFkfpCXwuc5jeF4KOlAz9Jw6fOl5aCu0DRdAq/JAhwuwUkZkaeKADiMlbkgFbOZmjz 0RPJ8aLzU31jpZjJJNOGNC0YjLOPWu+8nOFSBPkRppMuSyApvp2WqCQ20TNjWyPYaiK2 f6aw2Diw7Erw6ATIqWvli28IpzymI02yXtNjhnq7KIscFySuPKds562r0hGhVyIHsBk5 tMRw== X-Gm-Message-State: AOAM530NYdeQzQwLhg/+Be8GVLDFfnawnKm0Lu9USk8br9FTE9Qo8K1X 1+M5vg68OvV4BTnZCWRnu4vEtvkfotkj+qfAHFZTom0d1zhm9oAq8YSXxhD6MoxCBdAm6KCj4An 49QWkszbEXH8MBtJbl7w= X-Received: by 2002:ab0:6b:: with SMTP id 98mr9669159uai.86.1610724273184; Fri, 15 Jan 2021 07:24:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKTcWxgc0pXVaJXCjT8zcbO1p883teFU9fCMjGs8nKD/9nAKzPRkjwUjTgLoJAL9n2tjumNMd611vbkswiacY= X-Received: by 2002:ab0:6b:: with SMTP id 98mr9669139uai.86.1610724272943; Fri, 15 Jan 2021 07:24:32 -0800 (PST) MIME-Version: 1.0 References: <20201207173319.1397740-1-thomas@monjalon.net> <20210113190542.223445-1-thomas@monjalon.net> <1624576.mXulGEC3Iq@thomas> In-Reply-To: <1624576.mXulGEC3Iq@thomas> From: David Marchand Date: Fri, 15 Jan 2021 16:24:21 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] devtools: avoid installing static binaries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 13, 2021 at 11:01 PM Thomas Monjalon wrote: > > 13/01/2021 20:05, Thomas Monjalon: > > When testing compilation and checking ABI compatibility, > > there is no real need of static binaries eating disks. > > > > The static linkage of applications was already well tested, > > though the static examples tested with meson were limited to "l3fwd" only. > > The static build test with make is limited to "helloworld" example. > > > > The ABI compatibility is checked on shared libraries, > > and there is no need to test again on similar builds. > > A new parameter is added to the function "build", > > so the ABI check is enabled only for native gcc and clang shared builds, > > 32-bit, generic armv8 and ppc cross compilations. > > In other words, it is disabled for some static builds and some Arm ones. > > > > Signed-off-by: Thomas Monjalon > > --- > > v2: > > - separate ABI check enablement from default library > > - disable ABI check in specific Arm builds > > --- > [...] > > -build build-x86-default cc -Dlibdir=lib -Dmachine=$default_machine $use_shared > > +build build-x86-default cc ABI \ > > + -Dlibdir=lib -Dmachine=$default_machine $use_shared > > After a second thought, I think this one should be "skipABI". No opinion on this one. The title might need some tweak, since you also disabled the ABI check on some ARM targets. The rest lgtm. Acked-by: David Marchand -- David Marchand