From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 69285A0096
	for <public@inbox.dpdk.org>; Mon,  3 Jun 2019 21:32:02 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B74F01B9AF;
	Mon,  3 Jun 2019 21:32:01 +0200 (CEST)
Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com
 [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id E124D1B99F
 for <dev@dpdk.org>; Mon,  3 Jun 2019 21:31:59 +0200 (CEST)
Received: by mail-vs1-f67.google.com with SMTP id b10so12000001vsp.5
 for <dev@dpdk.org>; Mon, 03 Jun 2019 12:31:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=5tMXlbwoBah84mSrHxDYrHPvJCASIRNZwIUAQaQ517A=;
 b=L08gOnzymBFLOXbxBTi5yC4fv+ZIzhGoQEIC1++052ItGASWJG+tSyglYjvoeXfcci
 pPxZaCWzC8+q7WTRVd0/qAQzjAJ77Jz5uYGMjzqo9f61sofDrZWOal8t4/vBFYShaftB
 LCZuHum/Um3cZToo/Ej8cMvea7Vk3HlAz2RARTOC3z/RFdd/bnJwlWGBfhortyJTymWQ
 m2kKG/rVXzxabykqHZDa10Mg76DrnDtSPJj+3YhaVTs1IGgLFnTJH850tdjmd2j3Mept
 Qg0UlllDMzuC77+M2eHEWwDO34WxSr4z/vl3siJwZep303Z5j8dbC26xFXGCx9ytl+qz
 iRUA==
X-Gm-Message-State: APjAAAVYfZpDkmp1TVwq6u7BUoLVfLfkBpFehfQRB6QQ/8Xvmz02LGyJ
 DwB4HPnY2SVxrxK7CXV1dNFXjKSZykVJ8cd9bN4DMA==
X-Google-Smtp-Source: APXvYqwYeW3KjvG5E+RhZWK8RINv7RBEzapwAUbI6CDmAOX95ue+91q9RpUYqdPScsFPkxkIo2jU4SvrEcYdFIUPnQs=
X-Received: by 2002:a67:f998:: with SMTP id b24mr3268092vsq.180.1559590319335; 
 Mon, 03 Jun 2019 12:31:59 -0700 (PDT)
MIME-Version: 1.0
References: <20190531232723.2030-1-dharmik.thakkar@arm.com>
 <CAJFAV8x+zkU=L=uoz2rNyVhdQSg0AUMXU6r2M970N6LMBrE3xw@mail.gmail.com>
 <89DD5489-BABD-4BAA-8815-68F9D18BF301@arm.com>
In-Reply-To: <89DD5489-BABD-4BAA-8815-68F9D18BF301@arm.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 3 Jun 2019 21:31:48 +0200
Message-ID: <CAJFAV8xp7XN3FGa4iU+kPYrqnPc8UiHn5gOa5KEBbed_GQQ2vg@mail.gmail.com>
To: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>,
 Sameh Gobriel <sameh.gobriel@intel.com>, 
 Bruce Richardson <bruce.richardson@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>, 
 dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
 Michael Santana <msantana@redhat.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/hash: rectify slaveid to
 point to valid cores
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jun 3, 2019 at 6:57 PM Dharmik Thakkar <Dharmik.Thakkar@arm.com>
wrote:

> > On Jun 1, 2019, at 10:59 AM, David Marchand <david.marchand@redhat.com>
> wrote:
> > I would change the Fixes: tag, fix the checkpatch warning, and send it
> next week.
> I am not sure about this. Do we simply go by 'git blame' or insert the
> commit that truly introduced the error?
>

http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
See the part about Fixes:.

The purpose of this tag is to point at the commit that introduced an issue
so that stable maintainers can catch it with scripts and backport it in the
relevant branches.


-- 
David Marchand