From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A68C4339E; Wed, 22 Nov 2023 17:56:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 309A3410F2; Wed, 22 Nov 2023 17:56:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 61739410ED for ; Wed, 22 Nov 2023 17:56:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700672190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzEpCELQl8HIoYrIsKNIHSXqC1TOF4yI6+u7HM5niVw=; b=OOFR7PNKldkrRRU557fAiLrMpWZNDU3x7llEmCA++YKCFxuNhz21V9ANu6hJmUqhnDDajh sIMNo4MTfGotxxDlLFstuu87chpOOVmkCE1z47JSwXHfC8bGQ6zsvbqOgWOlzGzQUz1wps qWOcQ6Yo1X++Bvm+AUffEivL91n2LGg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-8T0CbWHIMNqv_AMavq4N8A-1; Wed, 22 Nov 2023 11:56:28 -0500 X-MC-Unique: 8T0CbWHIMNqv_AMavq4N8A-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c50d73e212so59050251fa.1 for ; Wed, 22 Nov 2023 08:56:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700672187; x=1701276987; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GzEpCELQl8HIoYrIsKNIHSXqC1TOF4yI6+u7HM5niVw=; b=SlqLidBFWTnMUfbsmoPPR9SMmoKCEgV6SIMcTQ3QG7fejBegr5p1Ulr+pJdOkXMh3t dhj4E7ifi3eMnxBssaOZVbvKRRA73A9H54Qt6aE9ZmLxXHHbjiYnj3plH8NA+Eh9oDOe a5Pm/IZdj1igZYD/EMV8cY29Z6KgdWn6kGNJ0N+jSrwps8fAbdP0SOp5313OzsIatcTS 0NQYIrUaxzYCcx18MhejHNvuB/PDPruSL4C8NCOb5KdumOLkTZ7XNHRnkBG9S0tMNViX MMwMUg0n+tJYOZ5cdIA8Z9wQLZAl6FUgnxryGbFoMSVqQwgnw0UEgql+gtxRuxRr8u22 ryEw== X-Gm-Message-State: AOJu0YwW68ZHSSo8uK/A4teHOXfO9hcWGQeMZXxicjF0DOA+PIm8UuuE lqsyBVETM2ug4MadhzMAKRkzLkKb+kTs4dBZydMdoWZD0mL533zByjf3Yke0JY3vb18tl8k+70B nURlnTPGA9Lb7TXHoqvc= X-Received: by 2002:a05:651c:2129:b0:2c6:ed45:8c94 with SMTP id a41-20020a05651c212900b002c6ed458c94mr2494703ljq.51.1700672186973; Wed, 22 Nov 2023 08:56:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEC2/gQetX4+kVFSv4kHoCDJFn/6JCDAzSUxUe7IDwPb5IVbZ0AQgiADFEUtZtMvYlz99mZNvhlcVomPJDlVfs= X-Received: by 2002:a05:651c:2129:b0:2c6:ed45:8c94 with SMTP id a41-20020a05651c212900b002c6ed458c94mr2494684ljq.51.1700672186654; Wed, 22 Nov 2023 08:56:26 -0800 (PST) MIME-Version: 1.0 References: <20231114170529.176665-1-getelson@nvidia.com> In-Reply-To: <20231114170529.176665-1-getelson@nvidia.com> From: David Marchand Date: Wed, 22 Nov 2023 17:56:15 +0100 Message-ID: Subject: Re: [PATCH] eal/windows: fix memory management macros usage To: Gregory Etelson Cc: dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, stable@dpdk.org, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 14, 2023 at 6:06=E2=80=AFPM Gregory Etelson wrote: > > Windows compilation with cross-mingw on Fedora 39 failed > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > already defined in the compiler environment: > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5710: note: > this is the location of the previous definition > > eal_memory.c:78: error: "MEM_RESERVE_PLACEHOLDER" redefined > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5715: note: > this is the location of the previous definition > > The patch masks MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER > macros if they were pre-defined by compiler. > > The patch also masks MEM_COALESCE_PLACEHOLDERS and > MEM_PRESERVE_PLACEHOLDER to prevent similar errors. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson Acked-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk Acked-by: Thomas Monjalon For the record, the same issue has been reported with Ubuntu 23.10. Applied, thanks. --=20 David Marchand