From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, "Wang, Yinan" <yinan.wang@intel.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
Adrian Moreno Zapata <amorenoz@redhat.com>,
Wei Ling <weix.ling@intel.com>, Yu Jiang <yux.jiang@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix secondary process crash with PCI devices
Date: Wed, 3 Feb 2021 18:03:48 +0100 [thread overview]
Message-ID: <CAJFAV8xqgWg2=yFPX-KHQfRKfWT1xLifDChD81n-KbYS9Dsu2A@mail.gmail.com> (raw)
In-Reply-To: <20210203155811.53005-1-maxime.coquelin@redhat.com>
On Wed, Feb 3, 2021 at 4:58 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> The Virtio rework series mistakenly moved the rte_pci_device
> pointer to struct virtio_hw, which is shared between the two
> processes. But this structure is per-process, so this change
> made secondary process to try accessing primary process-only
> memory, leading to a crash
crash.*
Ah the joy of multiprocess support :-).
>
> This patch reverts to proper behavior, by storing the
> rte_pci_device pointer into the pre-process
per*
> virtio_pci_internal struct. It provides also helper to get
also provides*
> the pointer from the virtio_hw struct pointer.
>
> Bugzilla ID: 633
> Fixes: c8d4b02f72ae ("net/virtio: move legacy IO to virtio PCI")
>
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
The patch lgtm.
Reviewed-by: David Marchand <david.marchand@redhat.com>
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-02-03 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:58 Maxime Coquelin
2021-02-03 17:03 ` David Marchand [this message]
2021-02-03 17:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xqgWg2=yFPX-KHQfRKfWT1xLifDChD81n-KbYS9Dsu2A@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=amorenoz@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=weix.ling@intel.com \
--cc=yinan.wang@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).