From: David Marchand <david.marchand@redhat.com>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: Xiaolong Ye <xiaolong.ye@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] examples/tep_term: remove redundant info get
Date: Fri, 21 Feb 2020 11:13:15 +0100 [thread overview]
Message-ID: <CAJFAV8xqkdboszY5-iVgS3jLoGoxWPvbO0hV50iJBAx5=a_2qg@mail.gmail.com> (raw)
In-Reply-To: <20200217014115.26572-1-xiaoyun.li@intel.com>
On Mon, Feb 17, 2020 at 2:41 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
>
> Removed redundant function call of 'rte_eth_dev_info_get()' since it has
> already been called earlier.
>
> Coverity issue: 349922
> Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Little comment, this patch solves a coverity issue.
Upon inspection of this example code, I can see no check on device
capability when sending packets.
So I suppose it is broken when user asks for TSO, but the devices do
not support TSO.
Can you investigate and fix this in the next release?
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-02-21 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 3:07 [dpdk-dev] [PATCH] examples/tep_term: fix return value check Xiaoyun Li
2020-02-10 3:36 ` Ye Xiaolong
2020-02-10 5:04 ` Li, Xiaoyun
2020-02-10 6:51 ` Ye Xiaolong
2020-02-10 7:04 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2020-02-10 7:04 ` Ye Xiaolong
2020-02-13 14:57 ` David Marchand
2020-02-17 1:49 ` Li, Xiaoyun
2020-02-17 1:41 ` [dpdk-dev] [PATCH v3] examples/tep_term: remove redundant info get Xiaoyun Li
2020-02-20 15:53 ` David Marchand
2020-02-21 1:19 ` Ye Xiaolong
2020-02-21 10:13 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xqkdboszY5-iVgS3jLoGoxWPvbO0hV50iJBAx5=a_2qg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).