From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35C29A0093; Mon, 2 May 2022 13:29:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D363740F35; Mon, 2 May 2022 13:29:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C760140E28 for ; Mon, 2 May 2022 13:29:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651490949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/WedEZO9Df0AL1t6tXeBn/+f3E66nXAjXxC2A6zDRzI=; b=LRwEszWU6rrrtAah5q39iFpCsWVZbzlcOOpmFY6Kvvu9jE7iU2HKKwK8JjEctvJElBpxmR T7QqYhRdV+/QQWFmDl3cx5cCiNU9Wl5LNIrgyzsopKOgVjaqqq7xUfB78/zCvYidu/hg4X Jcx0tHKQf4W5+rBkzRmRrm/agXkjTxI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-295--tTEg89uMQOWspE1jB6lvg-1; Mon, 02 May 2022 07:29:08 -0400 X-MC-Unique: -tTEg89uMQOWspE1jB6lvg-1 Received: by mail-lf1-f69.google.com with SMTP id h15-20020ac24daf000000b00472586ed83dso2632241lfe.22 for ; Mon, 02 May 2022 04:29:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/WedEZO9Df0AL1t6tXeBn/+f3E66nXAjXxC2A6zDRzI=; b=M/vQPBNw2/JT99KaYgHIEihErypA73oAi/ZfCwO3UcLn4yQ3tkc8KEX5NxVGSpddl2 eyRgiEebep5j4xNaRN9y7aZx1qozMI/vKgzNZOSo7Q3ecZAB+jrkSjFfytsa+Ass6uzM 3GNVkPjwz/SgQSnSw2B+QEGqLp7XjVLEYhSzNViN4QZZI2XbF2cLQGYziIc9q91gJQ/p +puVGP3s1TcIexJ7VvVW87k8P3qXmQyGp98JC52m3JWjhNzmwNug7tYwu3D0DJUVRd7O 6pJ8fEB+SopG0Sn5s+E5LCPVW220cGf7kXziwbRD9ItIuOuTvyrdzliNra85FA9ob4xs oLPA== X-Gm-Message-State: AOAM53205mvYed/xXP/a0kOv715NTbA7qSDZYdps51SFkVVN4ZDP+LZf CRwCgb9LXwFi7FxQyGurJaOBt/4bp5i7gXtWL/Dw7Em+S2Z0kDliVcps67MOlVU73zOYVH4Sa3V y1oK744S15fD416YAhJ4= X-Received: by 2002:a05:651c:179c:b0:247:e1b4:92aa with SMTP id bn28-20020a05651c179c00b00247e1b492aamr7787135ljb.55.1651490946694; Mon, 02 May 2022 04:29:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEkkT700HDNMG3T2pkDMagLom7jGVyqBuZzG2MDbn3O4OYJLr470omIi3za2z0A5c2AaLQ2uolldJmlL210Jc= X-Received: by 2002:a05:651c:179c:b0:247:e1b4:92aa with SMTP id bn28-20020a05651c179c00b00247e1b492aamr7787128ljb.55.1651490946483; Mon, 02 May 2022 04:29:06 -0700 (PDT) MIME-Version: 1.0 References: <20220422093543.386475-1-maxime.coquelin@redhat.com> In-Reply-To: <20220422093543.386475-1-maxime.coquelin@redhat.com> From: David Marchand Date: Mon, 2 May 2022 13:28:55 +0200 Message-ID: Subject: Re: [PATCH] net/vhost: fix TSO feature default disablement To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 22, 2022 at 11:35 AM Maxime Coquelin wrote: > > By default, TSO feature should be disabled because it requires > application's support to be functionnal as mentionned in the > documentation. > > However, if "tso" devarg was not specified, the feature did > not get disabled. > > This patch fixes this issue, so that TSO is disabled, even if > "tso=0" is not passed as devarg. > > Fixes: e289400669d5 ("net/vhost: support TSO disabling") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin LGTM. Reviewed-by: David Marchand -- David Marchand