From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A37BA0580; Tue, 22 Nov 2022 10:31:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3475742D2B; Tue, 22 Nov 2022 10:31:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0781B427EB for ; Tue, 22 Nov 2022 10:30:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669109459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pck6R5japSFTHoO+EK4FyOtx9C3Vr9UqJNvnVt0vxTU=; b=SIRJ98d0HPfPOleb5TXWhpdccLLvDWRFUY26BRFBZwcxFoE07fWry8+qul1kkUS3l/LJ67 ug3ivaiZE70ig3S6gNandT0ki0uzHi3dJLYW670Ssj+8eVLjqvESiGsm/uRHU+4C+4bTou Nye/beg6VstN571srqv9EAsUWRm+LxY= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-85-IEW7Lu13PR6yC7k5v8BaRw-1; Tue, 22 Nov 2022 04:30:57 -0500 X-MC-Unique: IEW7Lu13PR6yC7k5v8BaRw-1 Received: by mail-pl1-f200.google.com with SMTP id n16-20020a170902d2d000b00189082beeb4so7785699plc.16 for ; Tue, 22 Nov 2022 01:30:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pck6R5japSFTHoO+EK4FyOtx9C3Vr9UqJNvnVt0vxTU=; b=6qmPPCW2DNFduBmuYASOnCZ+yXQhTo/Qqnw2HtXqwUeVfPwirvVdyiXl/XoetZbuMt ApucvqVHHLTZ/6mhhwvpeScrUIqIXsZJvV96vHAc5VecQsYevodrxK6It9vQIpVi7s+J W6DXjmyTxNZOcbKyVtS7YEonaK7m+6zQ4BXpKMufiYR8HkXRdtfXBBlXNQi3EB2VZjo5 jlayJrn5Abd9izxGlz3Z1gKEBcOwkfOY70tS3JqfCY123DoOOHlf0K43o3FDz87oC8c6 czalCEHOh9KPWlQnMJi2olJnmuEdF9G/N565mz8M2g1HxEZctOKfIX5nXASNm6TQT2Md N5rg== X-Gm-Message-State: ANoB5plKihGMfJXR+RggCIpICb2YODJYiHNS1/g97Njz0Ca0BGRcU39d xwnEanPBPeWXcMQGtHPAx/v5v+MnGJ7o7yjWVVwdjb38rvXQybzk3FYWOX03Ng+SfBhnG5yJyvL bE5WWZhjlB3knYqxTv5c= X-Received: by 2002:a17:90a:f48d:b0:212:c877:e948 with SMTP id bx13-20020a17090af48d00b00212c877e948mr31219758pjb.39.1669109456569; Tue, 22 Nov 2022 01:30:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf5/3dCFZWndI88ytFjqElftFMwurJyMr4YaHDetpN1nKJ68p03xHTo9wfUfnVYNdTqWhKJqiW+QGzyRK9BjP9Y= X-Received: by 2002:a17:90a:f48d:b0:212:c877:e948 with SMTP id bx13-20020a17090af48d00b00212c877e948mr31219738pjb.39.1669109456285; Tue, 22 Nov 2022 01:30:56 -0800 (PST) MIME-Version: 1.0 References: <20221118133547.1203417-1-tomasz.zawadzki@intel.com> In-Reply-To: From: David Marchand Date: Tue, 22 Nov 2022 10:30:45 +0100 Message-ID: Subject: Re: [PATCH] bus/pci: fix bus info memleak during PCI scan To: Tomasz Zawadzki Cc: Bruce Richardson , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 21, 2022 at 9:44 AM David Marchand wrote: > > On Fri, Nov 18, 2022 at 2:36 PM Tomasz Zawadzki > wrote: > > > > During pci_scan_one() for devices that were already registered > > the pci_common_set() is called to set some of the fields again. > > > > This resulted in bus_info allocation leaking, so this patch > > ensures they are always freed beforehand. > > > > Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information") > > > > Signed-off-by: Tomasz Zawadzki I sent https://patchwork.dpdk.org/project/dpdk/patch/20221121111209.2396341-1-david.marchand@redhat.com/ as an alternative. Can you have a look? Thanks. -- David Marchand