From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 52E971B4D4 for ; Fri, 1 Feb 2019 13:02:06 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id v70so1505942vkv.7 for ; Fri, 01 Feb 2019 04:02:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+5xe7n588qJcHwFYKg5haHlaD4h0qAetT1gaYAegv28=; b=mjCiztYqB71/OMuJbPwPSzFyivnpH/IyIl/bOU7+p2bJLxhU63nba+ZuUTWO/iM8Cp Unp8rw+2AT5pVVPBlUqbGhN1TP86aiKK2mXUELqA5alvpgXBq9SlHUyaxSPiRM44fZe1 w4rhwsniigX5gMh2kE09rrbeAaskBmbIlCT15FPpSsVuToStoQWs+xcGqFcj3bOgseu3 KVxL5qC37Rh8VH/fSrJPriaz8dZ50fqB089hLb1vl3zAPMCdDYfJn+813Q5jgy2FJ5iU 9H2GZfjat6T9wfMtd/U2XwwnuOwGUKePxxuYpFCA+56RNPLXMiQyjoT9xHZgKi3iNNrV d3kw== X-Gm-Message-State: AJcUukcokr9IChwO/mrfFFzx3TTO/XWyB6eETV5rTJiz5XruqelowGvm xgTqOW4m1ul6Mx61qVj//e6JcNhWtXDAKsTTSFVPiw== X-Google-Smtp-Source: ALg8bN5bEdCs6JKerr73qefLc31gFidvDS4T60MZsCFHVPONcteFX0LAQtPy3//IV5CD38wG4LPcHNGEw5ImlB+C23g= X-Received: by 2002:a1f:19d6:: with SMTP id 205mr15641452vkz.53.1549022525618; Fri, 01 Feb 2019 04:02:05 -0800 (PST) MIME-Version: 1.0 References: <1548135866-98665-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1548135866-98665-1-git-send-email-nikhil.rao@intel.com> From: David Marchand Date: Fri, 1 Feb 2019 13:01:54 +0100 Message-ID: To: Nikhil Rao Cc: Neil Horman , harry.van.haaren@intel.com, dev@dpdk.org, Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 12:02:06 -0000 On Tue, Jan 22, 2019 at 6:46 AM Nikhil Rao wrote: > rte_service_attr_get() is passed a uint32_t * to retrieve > an attribute value, this will be changed to uin64_t * as per > patch posted at http://patchwork.dpdk.org/patch/49968/ > > Signed-off-by: Nikhil Rao > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index f9a1f81..398e967 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -60,3 +60,6 @@ Deprecation Notices > > * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version > will be > changed from 0.49.0 to 0.52.0. > + > +* The attr_value parameter of rte_service_attr_get() will be changed from > + uint32_t * to uint64_t * as the attributes are of type uint64_t. > Should the version in which the change is going to occur be part of the notice ? Apart from this, and since it fixes a problem in (mostly unused) rte_service_attr_get() api, Acked-by: David Marchand -- David Marchand