From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8239D41EB0; Thu, 16 Mar 2023 12:01:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71B1F42D3B; Thu, 16 Mar 2023 12:01:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4833C42D32 for ; Thu, 16 Mar 2023 12:01:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678964467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKPSmjoEvSG+JKFBY5a08I/ffJnelvJzmQYIKuhtLtI=; b=GuoJb7XLxBYn6YqCVTAy6Bt0XR7m5Ka7Omf5MKP4SMbKTiK2j7metlLyMXrI6YWd9o8amw wZnDwUr+pIgJwJBLOT9RgqZO29FqjWM9iAMLyPuf1ihhFyCYytUJEkmX1K4WWfyV6h5BPz mOh7AN6XXfIXEtlsE48qKSwZaCFx/OY= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-sOEpNK9YPxCjBCXNUH2djw-1; Thu, 16 Mar 2023 07:01:06 -0400 X-MC-Unique: sOEpNK9YPxCjBCXNUH2djw-1 Received: by mail-pl1-f198.google.com with SMTP id t24-20020a1709028c9800b0019eaa064a51so808668plo.10 for ; Thu, 16 Mar 2023 04:01:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678964465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RKPSmjoEvSG+JKFBY5a08I/ffJnelvJzmQYIKuhtLtI=; b=ZrON+pF1KU5u1m8AqhedJOHqNaviu8EqKA2PyghObmHETj2uJfu5Z+pj1Y44GrGUE1 Bp7VWPjj+wRp9CDuOsKDgTw9QeHQqNpHNZ/bMzdk0OSsHZ8epS/pO12MHAW+86c4aAcE hkgAwz7+V2nqxiEemNzmPtQC7xNkAM2sGBlJNJOWXFqGMtT834u0/Sf6sKozc03Tnfuu N+v91Yrhsf2mm6Rl/8oU99kts1WalQGdoKFhQiJ0CqeQIli7GvNXfssoTArY9nbsog7n SoIjg3F/UfKzou5GJNWxvypzW8qLqXy5ndDBuG7Gv/Yy3VXslmTqUYoiUVz47Fz80knF SQDQ== X-Gm-Message-State: AO0yUKUDUag/WPKe4zG5DEX8m6+4A2ww0zEM8RJp2yqu6iBtGUsG/v46 PMSGuXbcofltP5LOly3qwtRbxcNztvJsx8R6yrUsV23FfxoVORv6ufvr15+kjWXi0jov2Sxpuav IQvjDBhcvdeAwA6FCd1gJYEi/7XeC3A== X-Received: by 2002:a17:902:db09:b0:1a0:4be5:ccea with SMTP id m9-20020a170902db0900b001a04be5cceamr1174554plx.9.1678964465611; Thu, 16 Mar 2023 04:01:05 -0700 (PDT) X-Google-Smtp-Source: AK7set/FgtjzYEKZgwr+N5V8eoxk6i80cHRM+fa18N4h2JY5WxYtHm198ozzGVDUYlzf5OasM0jUVUy/5n0+v9LHvY8= X-Received: by 2002:a17:902:db09:b0:1a0:4be5:ccea with SMTP id m9-20020a170902db0900b001a04be5cceamr1174550plx.9.1678964465330; Thu, 16 Mar 2023 04:01:05 -0700 (PDT) MIME-Version: 1.0 References: <20221220123754.239802-1-ktraynor@redhat.com> In-Reply-To: <20221220123754.239802-1-ktraynor@redhat.com> From: David Marchand Date: Thu, 16 Mar 2023 12:00:54 +0100 Message-ID: Subject: Re: [PATCH 21.11] ring: squash gcc 12.2.1 warnings To: dev , Honnappa Nagarahalli , Konstantin Ananyev , Thomas Monjalon Cc: stable@dpdk.org, alialnu@nvidia.com, Bruce Richardson , Luca Boccassi , "Xueming(Steven) Li" , Patrick Robb , Kevin Traynor X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 20, 2022 at 1:38=E2=80=AFPM Kevin Traynor = wrote: > > gcc 12.2.1 on Fedora 37 is giving stringop-overread and > stringop-overflow warnings when compiled with --buildtype=3Ddebug > e.g. [1]. > > These are not yet fixed on main branch. They look similar > to the overflow issues previously squashed in rte_memcpy with > commit b5b3ea803e47 ("eal/x86: ignore gcc 10 stringop-overflow warnings") > > In order to ensure DPDK 21.11.3 compiles on Fedora 37, squash these > warnings. If a subsequent cleaner fix becomes available on from main > branch it can be backported to later DPDK 21.11 LTS release. > > [1] > lib/ring/rte_ring_elem_pvt.h:100:25: error: > =E2=80=98memcpy=E2=80=99 reading 32 bytes from a region of size 4 > [-Werror=3Dstringop-overread] > 100 | memcpy((void *)(ring + idx), > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 101 | (const void *)(obj + i), 32); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > lib/ring/rte_ring_elem_pvt.h:234:25: error: > =E2=80=98memcpy=E2=80=99 writing 32 bytes into a region of size 4 overflo= ws the destination > [-Werror=3Dstringop-overflow=3D] > 234 | memcpy((void *)(obj + i), (void *)(ring + idx), 32); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Kevin Traynor As mentionned in this thread: https://inbox.dpdk.org/dev/ZBLqF6c3ujMic45N@bricha3-MOBL.ger.corp.intel.com= /T/#me1c8f06a9ca2cf2a4ed4a028d373a3e3ce5146d1 I intend to pull this change in the main repository and mark this change for backports in other stable branches. I'll do this for -rc3, expected tomorrow, unless someone objects. --=20 David Marchand