From: David Marchand <david.marchand@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Flavio Leitner <fbl@sysclose.org>, dev <dev@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
Keith Wiles <keith.wiles@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags
Date: Wed, 28 Apr 2021 14:17:35 +0200 [thread overview]
Message-ID: <CAJFAV8xsXyPnMK6nXoDg_e4euDrd-jdd3kS5zQohS+3bfokpxw@mail.gmail.com> (raw)
In-Reply-To: <20210409133018.GB1650@platinum>
On Fri, Apr 9, 2021 at 3:30 PM Olivier Matz <olivier.matz@6wind.com> wrote:
> > I see your point. Going back to improving the documentation as a
> > first step, what would be the next steps? Are we going to wait few
> > releases and then remove the flag tweaking code assuming that PMDs
> > and apps are ok?
>
> After this documentation step, in few releases, we could relax the
> constraint on PMD: applications will be expected to set TCP_CKSUM when
> TCP_SEG is set, so no need for the PMD to force TCP_CKSUM to 1 if
> TCP_SEG is set. The documentation will be updated again.
>
> This plan can be described in the deprecation notice, and later in the
> release note.
Looking at drivers, some of them already trigger tcp checksumming with
the presence of PKT_TX_TCP_SEG only.
See for example:
https://git.dpdk.org/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx.c#n391
The hw needs to fill tcp checksum when generating segments.
So I suppose this was the original meaning of the "implies" comment.
https://git.dpdk.org/dpdk/tree/lib/mbuf/rte_mbuf_core.h#n292
We could reword the comment, but I don't think there is anything to
change in the API.
--
David Marchand
next prev parent reply other threads:[~2021-04-28 12:17 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:52 [dpdk-dev] [PATCH 0/5] Offload flags fixes David Marchand
2021-04-01 9:52 ` [dpdk-dev] [PATCH 1/5] mbuf: mark old offload flag as deprecated David Marchand
2021-04-07 20:14 ` Flavio Leitner
2021-04-08 7:23 ` Olivier Matz
2021-04-08 8:41 ` David Marchand
2021-04-01 9:52 ` [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags David Marchand
2021-04-07 20:15 ` Flavio Leitner
2021-04-08 7:41 ` Olivier Matz
2021-04-08 11:21 ` Flavio Leitner
2021-04-08 12:05 ` Olivier Matz
2021-04-08 12:58 ` Flavio Leitner
2021-04-09 13:30 ` Olivier Matz
2021-04-09 16:55 ` Flavio Leitner
2021-04-28 12:17 ` David Marchand [this message]
2021-04-08 12:16 ` Ananyev, Konstantin
2021-04-08 7:53 ` Olivier Matz
2021-04-28 12:12 ` David Marchand
2021-04-01 9:52 ` [dpdk-dev] [PATCH 3/5] net/virtio: " David Marchand
2021-04-13 14:17 ` Maxime Coquelin
2021-04-01 9:52 ` [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper David Marchand
2021-04-08 13:05 ` Flavio Leitner
2021-04-09 2:31 ` Ruifeng Wang
2021-04-01 9:52 ` [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path David Marchand
2021-04-08 8:28 ` Olivier Matz
2021-04-08 18:38 ` Flavio Leitner
2021-04-13 15:27 ` Maxime Coquelin
2021-04-27 17:09 ` David Marchand
2021-04-27 17:19 ` David Marchand
2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 0/4] Offload flags fixes David Marchand
2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 1/4] mbuf: mark old offload flag as deprecated David Marchand
2021-04-29 12:14 ` Lance Richardson
2021-04-29 16:45 ` Ajit Khaparde
2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 2/4] net/virtio: do not touch Tx offload flags David Marchand
2021-04-29 13:51 ` Flavio Leitner
2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 3/4] net/virtio: refactor Tx offload helper David Marchand
2021-04-29 12:59 ` Maxime Coquelin
2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 4/4] vhost: fix offload flags in Rx path David Marchand
2021-04-29 13:30 ` Maxime Coquelin
2021-04-29 13:31 ` Maxime Coquelin
2021-04-29 20:21 ` David Marchand
2021-04-30 8:38 ` Maxime Coquelin
2021-04-29 20:09 ` David Marchand
2021-04-29 18:39 ` Flavio Leitner
2021-04-29 19:18 ` David Marchand
2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 0/4] Offload flags fixes David Marchand
2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 1/4] mbuf: mark old offload flag as deprecated David Marchand
2021-05-03 14:02 ` Maxime Coquelin
2021-05-03 14:12 ` David Marchand
2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 2/4] net/virtio: do not touch Tx offload flags David Marchand
2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 3/4] net/virtio: refactor Tx offload helper David Marchand
2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 4/4] vhost: fix offload flags in Rx path David Marchand
2021-05-03 15:24 ` [dpdk-dev] [PATCH v3 0/4] Offload flags fixes Maxime Coquelin
2021-05-03 16:21 ` David Marchand
2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 0/3] " David Marchand
2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 1/3] net/virtio: do not touch Tx offload flags David Marchand
2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 2/3] net/virtio: refactor Tx offload helper David Marchand
2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 3/3] vhost: fix offload flags in Rx path David Marchand
2021-05-04 11:07 ` Flavio Leitner
2021-05-08 6:24 ` Wang, Yinan
2021-05-12 3:29 ` Wang, Yinan
2021-05-12 15:20 ` David Marchand
2021-05-13 6:34 ` Wang, Yinan
2021-05-04 8:29 ` [dpdk-dev] [PATCH v4 0/3] Offload flags fixes Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xsXyPnMK6nXoDg_e4euDrd-jdd3kS5zQohS+3bfokpxw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=fbl@sysclose.org \
--cc=ferruh.yigit@intel.com \
--cc=i.maximets@ovn.org \
--cc=keith.wiles@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).