From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26233A0C40; Wed, 28 Apr 2021 14:17:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4B7040697; Wed, 28 Apr 2021 14:17:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F49740147 for ; Wed, 28 Apr 2021 14:17:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619612270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pmQYFOcMpSDGC2qKLIq2vMoZH7XwvM4ub6crvU64klA=; b=Y1RpIsOZ/+NhYqvGcdDim+waQPNPDEyy5iLrYF54w1FR3HD691NqTjKoJmcw7em2k0U4+A 75jGaheP4Otj+4quyOXsI9pWYYIDSzflV9mm3RE9I4NIHxEg5uBSWpmaNFDGhFa5xaiFEX RNfqshHrj5jbetqxk5NnboUA4BunCCs= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-A9R7U2oeMcqJ-DjPV4ubAw-1; Wed, 28 Apr 2021 08:17:47 -0400 X-MC-Unique: A9R7U2oeMcqJ-DjPV4ubAw-1 Received: by mail-vk1-f200.google.com with SMTP id i68-20020a1f9f470000b02901ea52e1d796so852646vke.18 for ; Wed, 28 Apr 2021 05:17:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pmQYFOcMpSDGC2qKLIq2vMoZH7XwvM4ub6crvU64klA=; b=bl97SiBgu+IyuuE0i4kRgEhVNK4kk4hiPRWSk2E/WY/A9K6unsqyVPFMT6Be1Z9BM1 BYluazXZL4Kh9FuG3j8wMhrNp6vA/TE24mxlkcjkUAbeXltISvsdT00ptWjWRKZRPkMD Eg/5BfFUrP0g8d3M8dgpVKAfN88oyaMPfBQIVDEWPE2EIxZ8uxuqV/SqoG0iVdUPV81E 13TE/XJ3IUHKZeMjWKzZSLR+PI0OIGr2EH6+gjvdVB7jCVO4AuXkZL2zIuhl2BzfmwWL 1Rpclw4U8r7F8CXZchAWwTVFdvBexQWjyS9xmIUD9S1GyL9TXdhMqVtf00/hEJDjCIjL pXPg== X-Gm-Message-State: AOAM530R59odyfg2AjV43rgtuB4DhHGptT9NeBlj1a6Fk4Vi6VjcF3uJ ELs5h+cg5ug712l9EmnftzYFsc9ndOJrsaQrjP2nBFzpMRL5xUQ8aI6iCIUWKW8a9ZGSydqCqbY YSs/MgGBQDMVxeh+Rcro= X-Received: by 2002:a9f:368f:: with SMTP id p15mr17497141uap.41.1619612266635; Wed, 28 Apr 2021 05:17:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFcYF4DnZR0tonWCH6GlxVJJGDrkxk9E6sISoyZYeqhq0QOdnWfZBJb5a8MXqO1RgLl1NvrMTzEr/ugAryRc0= X-Received: by 2002:a9f:368f:: with SMTP id p15mr17497121uap.41.1619612266456; Wed, 28 Apr 2021 05:17:46 -0700 (PDT) MIME-Version: 1.0 References: <20210401095243.18211-1-david.marchand@redhat.com> <20210401095243.18211-3-david.marchand@redhat.com> <20210408074159.GQ1650@platinum> <20210408120521.GW1650@platinum> <20210409133018.GB1650@platinum> In-Reply-To: <20210409133018.GB1650@platinum> From: David Marchand Date: Wed, 28 Apr 2021 14:17:35 +0200 Message-ID: To: Olivier Matz Cc: Flavio Leitner , dev , Maxime Coquelin , Ilya Maximets , Keith Wiles , "Yigit, Ferruh" , Thomas Monjalon , Andrew Rybchenko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 9, 2021 at 3:30 PM Olivier Matz wrote: > > I see your point. Going back to improving the documentation as a > > first step, what would be the next steps? Are we going to wait few > > releases and then remove the flag tweaking code assuming that PMDs > > and apps are ok? > > After this documentation step, in few releases, we could relax the > constraint on PMD: applications will be expected to set TCP_CKSUM when > TCP_SEG is set, so no need for the PMD to force TCP_CKSUM to 1 if > TCP_SEG is set. The documentation will be updated again. > > This plan can be described in the deprecation notice, and later in the > release note. Looking at drivers, some of them already trigger tcp checksumming with the presence of PKT_TX_TCP_SEG only. See for example: https://git.dpdk.org/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx.c#n391 The hw needs to fill tcp checksum when generating segments. So I suppose this was the original meaning of the "implies" comment. https://git.dpdk.org/dpdk/tree/lib/mbuf/rte_mbuf_core.h#n292 We could reword the comment, but I don't think there is anything to change in the API. -- David Marchand