* [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion
@ 2020-04-17 15:25 David Marchand
2020-04-17 15:41 ` Thomas Monjalon
2020-04-18 22:20 ` David Christensen
0 siblings, 2 replies; 5+ messages in thread
From: David Marchand @ 2020-04-17 15:25 UTC (permalink / raw)
To: dev; +Cc: thomas, David Christensen
Compilation is broken on ppc:
CC otx2_rx.o
In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
.../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
error: expected declaration specifiers or ‘...’ before numeric constant
} __rte_aligned(16) rte_xmm_t;
^~
compilation terminated due to -Wfatal-errors.
Fixes: f35e5b3e07b2 ("replace alignment attributes")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/ppc/include/rte_vect.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/ppc/include/rte_vect.h b/lib/librte_eal/ppc/include/rte_vect.h
index a0dabf02eb..1d6c29be02 100644
--- a/lib/librte_eal/ppc/include/rte_vect.h
+++ b/lib/librte_eal/ppc/include/rte_vect.h
@@ -7,7 +7,9 @@
#define _RTE_VECT_PPC_64_H_
#include <altivec.h>
+
#include "generic/rte_vect.h"
+#include "rte_common.h"
#ifdef __cplusplus
extern "C" {
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion
2020-04-17 15:25 [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion David Marchand
@ 2020-04-17 15:41 ` Thomas Monjalon
2020-04-17 15:46 ` David Marchand
2020-04-18 22:20 ` David Christensen
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2020-04-17 15:41 UTC (permalink / raw)
To: David Marchand; +Cc: dev, David Christensen
17/04/2020 17:25, David Marchand:
> Compilation is broken on ppc:
>
> CC otx2_rx.o
> In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
> .../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
> error: expected declaration specifiers or ‘...’ before numeric constant
> } __rte_aligned(16) rte_xmm_t;
> ^~
> compilation terminated due to -Wfatal-errors.
>
> Fixes: f35e5b3e07b2 ("replace alignment attributes")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Sorry for not having tested PPC.
About the title:
eal/ppc: fix missing include
or
eal/ppc: fix build
?
Tested-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion
2020-04-17 15:41 ` Thomas Monjalon
@ 2020-04-17 15:46 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2020-04-17 15:46 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, David Christensen
On Fri, Apr 17, 2020 at 5:41 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 17/04/2020 17:25, David Marchand:
> > Compilation is broken on ppc:
> >
> > CC otx2_rx.o
> > In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
> > .../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
> > error: expected declaration specifiers or ‘...’ before numeric constant
> > } __rte_aligned(16) rte_xmm_t;
> > ^~
> > compilation terminated due to -Wfatal-errors.
> >
> > Fixes: f35e5b3e07b2 ("replace alignment attributes")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Sorry for not having tested PPC.
>
> About the title:
> eal/ppc: fix missing include
> or
> eal/ppc: fix build
> ?
>
> Tested-by: Thomas Monjalon <thomas@monjalon.net>
Applied.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion
2020-04-17 15:25 [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion David Marchand
2020-04-17 15:41 ` Thomas Monjalon
@ 2020-04-18 22:20 ` David Christensen
2020-04-19 6:57 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: David Christensen @ 2020-04-18 22:20 UTC (permalink / raw)
To: David Marchand, dev; +Cc: thomas
> Compilation is broken on ppc:
What commit ID were you testing that failed to build? This must be a
recent change as I'm not seeing it on my system.
Dave
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion
2020-04-18 22:20 ` David Christensen
@ 2020-04-19 6:57 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2020-04-19 6:57 UTC (permalink / raw)
To: David Christensen; +Cc: dev, Thomas Monjalon
On Sun, Apr 19, 2020 at 12:20 AM David Christensen
<drc@linux.vnet.ibm.com> wrote:
>
> > Compilation is broken on ppc:
> What commit ID were you testing that failed to build? This must be a
> recent change as I'm not seeing it on my system.
The failure was seen at b11ecebc0.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-19 6:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 15:25 [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion David Marchand
2020-04-17 15:41 ` Thomas Monjalon
2020-04-17 15:46 ` David Marchand
2020-04-18 22:20 ` David Christensen
2020-04-19 6:57 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).