From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D6EEA04DD; Thu, 22 Oct 2020 13:53:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5CFAA9C5; Thu, 22 Oct 2020 13:53:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id C1736A9C0 for <dev@dpdk.org>; Thu, 22 Oct 2020 13:53:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603367584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6TIT/gWH1ePAxfe/pFstcPzBSKLHRLwyD2k4zRYn350=; b=CcgE7c7YWjvwW1OyTTCi9FbexkyWHkWAeUeAtISUfXhNFz+47eFDj1D4UBQlTWp1bW576Z zrlU/mY2tanVeVojpZqF9fVvUXT+dZnIvHkhokN/s8uuyXPxXsD9fxKrcacE4OJ4yO83RO 5zQ+KGSCFuy3ubSBm8qwrCKCbdJTUbc= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-x4mzRtT_MHCMrU3xFE8lyA-1; Thu, 22 Oct 2020 07:53:00 -0400 X-MC-Unique: x4mzRtT_MHCMrU3xFE8lyA-1 Received: by mail-vs1-f71.google.com with SMTP id q28so238949vsr.20 for <dev@dpdk.org>; Thu, 22 Oct 2020 04:53:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6TIT/gWH1ePAxfe/pFstcPzBSKLHRLwyD2k4zRYn350=; b=ho10KxSl//VL27rF+JTlqYrZqCuZsx7KGWwq7ikZZLiDmmN9u+N4fVTLYtDMtDADi4 uGEYN0RIk0nvYQaRm/mOcZ/2MMqC4c9eGznXbnyOJKuONJAm6+UA8RUQbvdSl2nG0edw kCXHc1wa2sCDb6tyZSFcgylmMPZ5mC4bdpLlVIwB8tDC6OCYG+ExadQFUjVf5mp24gsz 1hmNcdX2+/Thoee7Irw2bkg4SvpypYHkAwElLzyUIR2fXa9b7S9WYr5Saotpws0XcXl2 CjDwbjbyxvlyeZkznMLkPypzjtFcLDGyFHnaPHXLRAVK2cewKCYVgtL+jJdJUohevSsr LVFQ== X-Gm-Message-State: AOAM532FOtQ/WSw9fmPR8tj5hfzR+De75HvCNInMacUhMpl6pB9FvsUU flX+G1epe2T2PopbW9cUueRT3P5inyLEntjsdwYnRhZ/hoqP/hG5D4pUFP9/1Xy1QnFFwk/n2/1 AESZ54yDeuUrURKCP9Og= X-Received: by 2002:a67:2fca:: with SMTP id v193mr1188279vsv.18.1603367580099; Thu, 22 Oct 2020 04:53:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXUiPwhIMNIfBI35efAUxFdWy8hAEqIF/ma6pi/ibZtXI0ne/T5WU+1RkfCEI0AJquizETDo2TpJxTYH4bDQk= X-Received: by 2002:a67:2fca:: with SMTP id v193mr1188257vsv.18.1603367579865; Thu, 22 Oct 2020 04:52:59 -0700 (PDT) MIME-Version: 1.0 References: <cover.1603102577.git.vladimir.medvedkin@intel.com> <cover.1603119828.git.vladimir.medvedkin@intel.com> <de5ef91ffa2e9a8184be2b768eac23fd79172abe.1603119828.git.vladimir.medvedkin@intel.com> In-Reply-To: <de5ef91ffa2e9a8184be2b768eac23fd79172abe.1603119828.git.vladimir.medvedkin@intel.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 22 Oct 2020 13:52:48 +0200 Message-ID: <CAJFAV8xt9tuxOsmm6OWZEz+-sB9gD0dtYBiaTbvcZDzsUsV5Kw@mail.gmail.com> To: Vladimir Medvedkin <vladimir.medvedkin@intel.com> Cc: dev <dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Ray Kinsella <mdr@ashroe.eu>, Thomas Monjalon <thomas@monjalon.net>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Ciara Power <ciara.power@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v13 1/7] fib: make lookup function type configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Oct 19, 2020 at 5:05 PM Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote: > > Add type argument to dir24_8_get_lookup_fn() > Now it supports 3 different lookup implementations: > RTE_FIB_DIR24_8_SCALAR_MACRO > RTE_FIB_DIR24_8_SCALAR_INLINE > RTE_FIB_DIR24_8_SCALAR_UNI > > Add new rte_fib_set_lookup_fn() - user can change lookup > function type runtime. > > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> We create a fib object with a type: either RTE_FIB_DUMMY or RTE_FIB_DIR24_8 (separate topic, we probably do not need RTE_FIB_TYPE_MAX). This lookup API is dir24_8 specific. If we won't abstract the lookup selection type, why not change this API as dir24_8 specific? I.e. s/rte_fib_set_lookup_fn/rte_fib_dir24_8_set_lookup_fn/g The same would apply to FIB6 trie implementation. -- David Marchand