From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13675A0C45; Wed, 20 Oct 2021 08:14:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D46ED40150; Wed, 20 Oct 2021 08:14:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CE1A240142 for ; Wed, 20 Oct 2021 08:14:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634710476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4rFogeJxhCR+zrAM3zzXBdF3O2vSvo7nsbkhGSE2OIY=; b=iQkEDwDFFJmOYr0fo5V1OG3MSOHM6sT8bjwhPh99S/BAhU6YdT2CPm4Mi5dPwvdWcTSFP+ 9y5NYPLXrOOZ7S/AkdmLf8g9AaUm/MQpF77dGpzfWErakuH1F/WA333fe0jvdujrD2b6VJ axK+5nAIUfCTwsRtwlZ3w//PQBVjxEk= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-jcOXQSxYPPuj374MxgzkLw-1; Wed, 20 Oct 2021 02:14:34 -0400 X-MC-Unique: jcOXQSxYPPuj374MxgzkLw-1 Received: by mail-lj1-f200.google.com with SMTP id k12-20020a2ea26c000000b00210f22d4769so1409005ljm.4 for ; Tue, 19 Oct 2021 23:14:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4rFogeJxhCR+zrAM3zzXBdF3O2vSvo7nsbkhGSE2OIY=; b=m6CM8Z41RlsHUv4BEpCeUSaEzdAdJ9WRPpZHr5PeVb9JB6xKtwsEZjjQk7GqVoZX4G Jbkq+WncA3Xm70+aD7T+stuD+h259fvKvvhBdgBx5ppJi1CLCDHnd1HrQ8R/ovEiJoSP 9L8wJz7YygaUOTwSL9GfecTYX03JcKX78VT+or7p3mPE9sdTKlPCIUqRFTh4RsiIf+Jj djz9brEzmQqtDgkMdZ1mu8Q9rAE6G4enjYH2FduIbbgI3Z+CvgEhTBa0K2pVm8j7WWi2 86BA03s+wPrHIw5D3GlaFSeOp5yaPBdauhE0S9YaBb4QxPUD0MFSdSV7fR3Bfw2/za1P tD3w== X-Gm-Message-State: AOAM532rSqgFUs09VNfao4foFptJ59d+CTaBFYF73OHpAEc6s1a/Vk4z D6wonfGATClRLv7gNTWHa/+lx4bSZpwH+plR4YDbT1Wq7hWJTMsCxygcLJNKFTZgW+Z4CGdOhfB 17AykauCboAewrIiiQK8= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr10394464lfe.217.1634710473153; Tue, 19 Oct 2021 23:14:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8nmWkURPzt+DCdWZX2UmsB17m4UENCqxYUm5KfL6UZdOFBZ58yaECIjvAx2uiQwowPfeXgyW55NmT0V7VyEo= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr10394448lfe.217.1634710472912; Tue, 19 Oct 2021 23:14:32 -0700 (PDT) MIME-Version: 1.0 References: <20210826145726.102081-1-hkalra@marvell.com> <20211019183543.132084-1-hkalra@marvell.com> <20211019183543.132084-3-hkalra@marvell.com> In-Reply-To: <20211019183543.132084-3-hkalra@marvell.com> From: David Marchand Date: Wed, 20 Oct 2021 08:14:21 +0200 Message-ID: To: Harman Kalra Cc: dev , Thomas Monjalon , Ray Kinsella , Dmitry Kozlyuk Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 2/7] eal/interrupts: implement get set APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 8:36 PM Harman Kalra wrote: > diff --git a/lib/eal/version.map b/lib/eal/version.map > index 38f7de83e1..7112dbc146 100644 > --- a/lib/eal/version.map > +++ b/lib/eal/version.map > @@ -109,18 +109,10 @@ DPDK_22 { > rte_hexdump; > rte_hypervisor_get; > rte_hypervisor_get_name; # WINDOWS_NO_EXPORT > - rte_intr_allow_others; > rte_intr_callback_register; > rte_intr_callback_unregister; > - rte_intr_cap_multiple; > - rte_intr_disable; > - rte_intr_dp_is_en; > - rte_intr_efd_disable; > - rte_intr_efd_enable; > rte_intr_enable; > - rte_intr_free_epoll_fd; > - rte_intr_rx_ctl; > - rte_intr_tls_epfd; > + rte_intr_disable; Please sort symbols alphabetically, this patch moves rte_intr_disable after rte_intr_enable. > rte_keepalive_create; # WINDOWS_NO_EXPORT > rte_keepalive_dispatch_pings; # WINDOWS_NO_EXPORT > rte_keepalive_mark_alive; # WINDOWS_NO_EXPORT > @@ -420,12 +412,49 @@ EXPERIMENTAL { > > # added in 21.08 > rte_power_monitor_multi; # WINDOWS_NO_EXPORT > + > + # added in 21.11 > + rte_intr_fd_get; # WINDOWS_NO_EXPORT > + rte_intr_fd_set; # WINDOWS_NO_EXPORT > + rte_intr_instance_alloc; > + rte_intr_instance_free; > + rte_intr_type_get; > + rte_intr_type_set; > }; > > INTERNAL { > global: > > rte_firmware_read; > + rte_intr_allow_others; > + rte_intr_cap_multiple; > + rte_intr_dev_fd_get; # WINDOWS_NO_EXPORT > + rte_intr_dev_fd_set; # WINDOWS_NO_EXPORT > + rte_intr_dp_is_en; > + rte_intr_efd_counter_size_set; # WINDOWS_NO_EXPORT > + rte_intr_efd_counter_size_get; # WINDOWS_NO_EXPORT > + rte_intr_efd_disable; > + rte_intr_efd_enable; > + rte_intr_efds_index_get; # WINDOWS_NO_EXPORT > + rte_intr_efds_index_set; # WINDOWS_NO_EXPORT > + rte_intr_elist_index_get; > + rte_intr_elist_index_set; > + rte_intr_event_list_update; > + rte_intr_free_epoll_fd; > + rte_intr_instance_copy; > + rte_intr_instance_windows_handle_get; > + rte_intr_instance_windows_handle_set; > + rte_intr_max_intr_get; > + rte_intr_max_intr_set; > + rte_intr_nb_efd_get; # WINDOWS_NO_EXPORT > + rte_intr_nb_efd_set; # WINDOWS_NO_EXPORT > + rte_intr_nb_intr_get; # WINDOWS_NO_EXPORT > + rte_intr_rx_ctl; > + rte_intr_tls_epfd; > + rte_intr_vec_list_alloc; > + rte_intr_vec_list_free; > + rte_intr_vec_list_index_get; > + rte_intr_vec_list_index_set; > rte_mem_lock; > rte_mem_map; > rte_mem_page_size; I see at least one link issue on Windows: FAILED: lib/rte_ethdev-22.dll "clang" -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_ethdev-22.dll lib/librte_ethdev.a.p/ethdev_ethdev_private.c.obj lib/librte_ethdev.a.p/ethdev_ethdev_profile.c.obj lib/librte_ethdev.a.p/ethdev_ethdev_trace_points.c.obj lib/librte_ethdev.a.p/ethdev_rte_class_eth.c.obj lib/librte_ethdev.a.p/ethdev_rte_ethdev.c.obj lib/librte_ethdev.a.p/ethdev_rte_flow.c.obj lib/librte_ethdev.a.p/ethdev_rte_mtr.c.obj lib/librte_ethdev.a.p/ethdev_rte_tm.c.obj "-Wl,/nologo" "-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL" "-Wl,/IMPLIB:lib\rte_ethdev.lib" "lib\rte_eal.lib" "lib\rte_kvargs.lib" "lib\rte_net.lib" "lib\rte_mbuf.lib" "lib\rte_mempool.lib" "lib\rte_ring.lib" "lib\rte_meter.lib" "lib\rte_telemetry.lib" "-Wl,/def:C:\Users\builder\jenkins\workspace\Windows-Compile-DPDK-Meson\dpdk\build\lib\rte_ethdev_exports.def" "-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32" "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" "-lcomdlg32" "-ladvapi32" Creating library lib\rte_ethdev.lib and object lib\rte_ethdev.exp ethdev_rte_ethdev.c.obj : error LNK2019: unresolved external symbol rte_intr_efds_index_get referenced in function rte_eth_dev_rx_intr_ctl_q_get_fd lib\rte_ethdev-22.dll : fatal error LNK1120: 1 unresolved externals AFAIU, eal_common_interrupts.c hosts those new symbols and this file is compiled for Windows (from common/meson.build update), so all intr symbols are available. There is no reason to filter interrupts symbols for Windows, is there? -- David Marchand