DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Maryam Tahhan <maryam.tahhan@intel.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>,
	 Roman Korynkevych <romanx.korynkevych@intel.com>,
	 Harry van Haaren <harry.van.haaren@intel.com>,
	dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition
Date: Wed, 18 Nov 2020 15:10:01 +0100
Message-ID: <CAJFAV8xu-Hsk_3WQmBLphOYb7rr1rrwqg_-w7XyV_+DESuG-Sw@mail.gmail.com> (raw)
In-Reply-To: <20201118114525.99053-2-ferruh.yigit@intel.com>

On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> '_filters' is compared twice, second one will be always false, removing
> it using the message more relevant to the '_filters'.
>
> Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  app/proc-info/main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index d743209f0d..35e5b596eb 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -420,11 +420,9 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len,
>         } else if ((type_end != NULL) &&
>                    (strncmp(cnt_name, "flow_", strlen("flow_"))) == 0) {
>                 if (strncmp(type_end, "_filters", strlen("_filters")) == 0)
> -                       strlcpy(cnt_type, "operations", cnt_type_len);
> +                       strlcpy(cnt_type, "filter_result", cnt_type_len);

Do you know what impact this change of type could have?


-- 
David Marchand


  reply	other threads:[~2020-11-18 14:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 17:14 [dpdk-dev] [PATCH 0/4] cppcheck Ferruh Yigit
2020-11-17 17:14 ` [dpdk-dev] [PATCH 1/4] app/procinfo: fix redundant condition Ferruh Yigit
2020-11-17 17:14 ` [dpdk-dev] [PATCH 2/4] app/procinfo: fix negative check on unsigned variable Ferruh Yigit
2020-11-17 17:14 ` [dpdk-dev] [PATCH 3/4] app/procinfo: remove suspicious sizeof Ferruh Yigit
2020-11-17 18:07   ` Varghese, Vipin
2020-11-17 17:14 ` [dpdk-dev] [PATCH 4/4] app/procinfo: remove useless assignment Ferruh Yigit
2020-11-17 18:04   ` Varghese, Vipin
2020-11-18 10:46     ` Ferruh Yigit
2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 0/7] cppcheck Ferruh Yigit
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition Ferruh Yigit
2020-11-18 14:10     ` David Marchand [this message]
2020-11-19  9:34       ` Ferruh Yigit
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 2/7] app/procinfo: fix negative check on unsigned variable Ferruh Yigit
2020-11-18 14:10     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 3/7] app/procinfo: remove suspicious sizeof Ferruh Yigit
2020-11-18 14:10     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 4/7] app/procinfo: remove useless assignment Ferruh Yigit
2020-11-18 14:11     ` David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 5/7] net/pcap: remove local variable shadown outer one Ferruh Yigit
2020-11-18 14:11     ` David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 6/7] net/af_xdp: remove useless assignment Ferruh Yigit
2020-11-18 14:42     ` David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 7/7] net/bnxt: fix redundant return Ferruh Yigit
2020-11-18 14:42     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-18 16:12       ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xu-Hsk_3WQmBLphOYb7rr1rrwqg_-w7XyV_+DESuG-Sw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=maryam.tahhan@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=romanx.korynkevych@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git