From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/ice: fix assumption about tag placement order
Date: Thu, 17 Jul 2025 10:36:31 +0200 [thread overview]
Message-ID: <CAJFAV8xu0D272PkB3TKK1H59HA+QEE_sKqtRAo=ss41MHeQQqw@mail.gmail.com> (raw)
In-Reply-To: <aHi1Nnvl4_ezD74S@bricha3-mobl1.ger.corp.intel.com>
On Thu, Jul 17, 2025 at 10:33 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Thu, Jul 17, 2025 at 10:19:24AM +0200, David Marchand wrote:
> > On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > >
> > > The specific placement of outer/inner VLAN tags in E810 and related NICs
> > > is configurable. Therefore, remove the assumption that if the L2Tag2
> > > field is filled in, that the L2Tag1 must also be. Instead, check the
> > > existing mbuf VLAN flags, and move tags and set flags as appropriate.
> > > This fixes an issue where, with QinQ packets with different Tag ethtypes
> > > (0x88a8 vs 0x8100), we get an mbuf reporting two valid tags, but only
> > > having had one tag stripped.
> > >
> > > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > The ice code seems copy/pasted from i40e.
> > So I guess i40e is affected as well.
> >
>
> I'll investigate more. These fixes I intend for 25.11 anyway, since I'd
iavf has a similar helper.
> rather not risk them late in the 25.07 release cycle.
Yes, too late for the current release.
--
David Marchand
prev parent reply other threads:[~2025-07-17 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 17:39 Bruce Richardson
2025-07-17 8:19 ` David Marchand
2025-07-17 8:32 ` Bruce Richardson
2025-07-17 8:36 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xu0D272PkB3TKK1H59HA+QEE_sKqtRAo=ss41MHeQQqw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).