From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEC8BA0505; Tue, 5 Apr 2022 09:05:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9011140685; Tue, 5 Apr 2022 09:05:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 089BD40042 for <dev@dpdk.org>; Tue, 5 Apr 2022 09:05:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649142341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iVwK1kJkfNCf82ZJQZf9vDULGvvYPuyjbIrKquPEzKM=; b=W8fpOV6ypwY1CWsbMDnMqNiPwJoSwmVS3vOFQ+8Y7+X+wCzMJN9WZTD/cC83tVDvJsrVQZ I4InWoeocEIMcmta41mR0C0OT/yoRSkhpduhP/SKfhvmvBGILYN6GXUmjkytl2YiNvlS4M ynmpeulE5QRNoY2aknR48SAyyPf6tXM= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-sXgwSUtTObC4gKVUFKlNPw-1; Tue, 05 Apr 2022 03:05:40 -0400 X-MC-Unique: sXgwSUtTObC4gKVUFKlNPw-1 Received: by mail-lf1-f69.google.com with SMTP id h14-20020a056512220e00b0044a1337e409so4705459lfu.12 for <dev@dpdk.org>; Tue, 05 Apr 2022 00:05:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iVwK1kJkfNCf82ZJQZf9vDULGvvYPuyjbIrKquPEzKM=; b=khO6I3L2lrsZhnuwNjnjOgcs5snidTaLrVH6bdzmWK2gwyYmCk8sCmDZAu6qSW313L /bOImgVdyD3racA5sOwfrWXoGkxMcwjt3Hjlxsd9NMeFdh7Zs8fwaPGeTAKEmReVgRWU RqUjG14PAILee2uOLs6EgT26z/Dw11e/x3FprvfQ8/60LSdQtVrG3DrPcQKNP2aHVIPS z2E/hElnd0wGjTTGY+C6nVYvysh7vSlgSFcRAZ9L6FsXz9nxUAFXrxM6d1OUR++EVU2Y 2ASwuEqQuc/XCKssHG3Fw7Csw7w7kCENQJlk7EYbRJ+ZPkrEDChp/PJlWqWsiiNYOpSf 9Kqw== X-Gm-Message-State: AOAM533lb4JprL8ifI90kWZKaile1MFgiZpk/UQsV5NbakbusRCwUJWM nV6ELrhIoR/9zJSXPXJseDBOh59ZO+pqsIdg2mQZRzo8AT44eioMSUklIsJ4wsnOTJpg0RUcWQl N1sKWshwOMq9mWYc3jS0= X-Received: by 2002:a05:6512:1389:b0:45d:30d4:8cdd with SMTP id p9-20020a056512138900b0045d30d48cddmr1662248lfa.484.1649142338774; Tue, 05 Apr 2022 00:05:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlGN66ebKQmEho8sZBE+j3BrLHOBlK8Dgn1fUO1BQ0iTwgMbUC06+d711kGGpp5rhLD6rH0qLW8mWq4kXLQKI= X-Received: by 2002:a05:6512:1389:b0:45d:30d4:8cdd with SMTP id p9-20020a056512138900b0045d30d48cddmr1662230lfa.484.1649142338585; Tue, 05 Apr 2022 00:05:38 -0700 (PDT) MIME-Version: 1.0 References: <20220323093001.20618-1-david.marchand@redhat.com> <20220401084419.21150-1-david.marchand@redhat.com> <20220401084419.21150-2-david.marchand@redhat.com> In-Reply-To: <20220401084419.21150-2-david.marchand@redhat.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 5 Apr 2022 09:05:27 +0200 Message-ID: <CAJFAV8xu2ED3S1653TmTbRGKu7MWddcaFbiHfZb8Sxoxehh_hw@mail.gmail.com> Subject: Re: [PATCH v2 2/2] eal: factorize lcore main loop To: dev <dev@dpdk.org> Cc: Thomas Monjalon <thomas@monjalon.net>, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Bruce Richardson <bruce.richardson@intel.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Dodji Seketeli <dodji@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Apr 1, 2022 at 10:44 AM David Marchand <david.marchand@redhat.com> wrote: > > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisatio= n > between main and threads and factorize the rest as common code. > Thread id are now logged as string in a common format across OS. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > --- > Changes since v1: > - rebased on top of Tyler fix for Windows and new cleanup, FYI, this series needs a respin to fix Windows build (/me hides..). There is also a false positive ABI breakage reported by libabigail that Dodji is looking into. --=20 David Marchand