From: David Marchand <david.marchand@redhat.com>
To: Maryam Tahhan <mtahhan@redhat.com>
Cc: ferruh.yigit@amd.com, stephen@networkplumber.org,
lihuisong@huawei.com, fengchengwen@huawei.com,
liuyonglong@huawei.com, shibin.koikkara.reeny@intel.com,
ciara.loftus@intel.com, dev@dpdk.org
Subject: Re: [v6] net/af_xdp: enable uds_path instead of use_cni
Date: Thu, 21 Dec 2023 12:57:58 +0100 [thread overview]
Message-ID: <CAJFAV8xu3+dx3HLLv0cmHAqD6fLd59Zm9E2C8Ma-e_oaMekGSw@mail.gmail.com> (raw)
In-Reply-To: <f5174066-5292-4647-8249-49e26f552ed8@redhat.com>
On Thu, Dec 21, 2023 at 12:46 PM Maryam Tahhan <mtahhan@redhat.com> wrote:
> > If there are fixes mixed in, please separate them in dedicated patches
> > so we can backport them to LTS releases.
>
> Thanks for the Feedback David, I don't quite understand the ask here, is to to have a separate patch for documentation to fixes? As previous feedback in the mailing list was to keep the documentation changes with the fix.
>
> There is one fix in this patchset (for for broken socket behaviour). The rest of the changes were fixing up all the documentation. So do I need to create a patchset with multiple patches, one for the c code and separate ones for the documentation?
Ideally yes.
If the documentation fix relates to the code fix, it shall go as one patch.
Otherwise the doc fix can go as a separate patch.
And then after those fixes, the last patch of the series would be your
enhancement change.
Thanks.
--
David Marchand
prev parent reply other threads:[~2023-12-21 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 15:39 Maryam Tahhan
2023-12-21 10:44 ` Koikkara Reeny, Shibin
2023-12-21 11:36 ` David Marchand
2023-12-21 11:46 ` Maryam Tahhan
2023-12-21 11:57 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xu3+dx3HLLv0cmHAqD6fLd59Zm9E2C8Ma-e_oaMekGSw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=mtahhan@redhat.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).