From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C91C4A318B for ; Fri, 18 Oct 2019 10:47:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DFB51C0C3; Fri, 18 Oct 2019 10:47:51 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 89EB11C035 for ; Fri, 18 Oct 2019 10:47:50 +0200 (CEST) Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9F23796EB for ; Fri, 18 Oct 2019 08:47:49 +0000 (UTC) Received: by mail-ua1-f72.google.com with SMTP id 13so672919uag.22 for ; Fri, 18 Oct 2019 01:47:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SGCvmrCC1QKhk8UgUYmKoMvMEOoLa4xBgF3Q8CC1F7Y=; b=kzdU94D7FSMVrBoWJsP6gocuV/3bpE+gNk6sISAhIHD6PRbO1pOg3odfRdtL4epKR6 ry4MOFGe0gmDLiIXar01/f80CxgLwUp1in2AXLq3lQsXhDKj7SAr2d0kSJabDGVfvq6u ZtsU2fTdmAxEt14NwLKcNkdwzTAjq3iAAEUkfXlnZZm9W2X3Grf4+DnZc6Hf38UJE+xI 5SR2GczXgzh+3uFdVxmnDA/a/vU7WRBA3R8l2W4e7/m/Ya3dAaI1qkPtIIKRWy9pZEWE JQAZMueQT/rwMQZUKdsWsviLxzz0aj1IwoS3bGbTqcNQudXRJr1hVQgjMCuspCvVh/eC nwQw== X-Gm-Message-State: APjAAAWPZBGJhdOE5Xd7dB25xa0kkw5YIlzIYC9mYiglV+/8Dp6u1wTC AOUhZEUli5beA4u0x4fvxBgrFjpc6OPhI0//acFkyQ0DYr23fU1GwEaPhc7ZCS5vLnWsHh07GY4 yd8nGSs7HXyBURnhhOG8= X-Received: by 2002:a67:fc49:: with SMTP id p9mr4561355vsq.198.1571388469180; Fri, 18 Oct 2019 01:47:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzsKlOna4vP/yIgoinaxdIl1QJN8VxycB4KWnvRmTK4YRUEItAmuCO0pwmQVXSxy1rCmmBfy8h+TudRfctJa0Q= X-Received: by 2002:a67:fc49:: with SMTP id p9mr4561351vsq.198.1571388468928; Fri, 18 Oct 2019 01:47:48 -0700 (PDT) MIME-Version: 1.0 References: <1569585482-24513-1-git-send-email-david.marchand@redhat.com> <20191018084321.5cd5qtjnmeb4gdiu@platinum> In-Reply-To: <20191018084321.5cd5qtjnmeb4gdiu@platinum> From: David Marchand Date: Fri, 18 Oct 2019 10:47:37 +0200 Message-ID: To: Olivier Matz Cc: dev , Ian Stokes , Ilya Maximets , Kevin Traynor Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net: add missing endianness annotations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 18, 2019 at 10:43 AM Olivier Matz wrote: > > Hi David, > > 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: > > OVS currently maintains a copy of those headers with the right endianness > > annotations so that sparse checks can pass. > > > > We introduced rte_beXX_t for better readibility in v17.08. > > Let's make use of them, OVS then only needs to override those rte_beXX_t > > types by exposing a tweaked rte_byteorder.h header. > > > > Other existing dpdk users won't be affected since rte_beXX_t types are > > mapped to uintXX_t types. > > > > Signed-off-by: David Marchand > > --- > > lib/librte_net/rte_icmp.h | 12 +++++++----- > > lib/librte_net/rte_ip.h | 28 ++++++++++++++-------------- > > lib/librte_net/rte_sctp.h | 10 ++++++---- > > lib/librte_net/rte_tcp.h | 20 +++++++++++--------- > > lib/librte_net/rte_udp.h | 10 ++++++---- > > 5 files changed, 44 insertions(+), 36 deletions(-) > > Is there a reason why you didn't change arp, gre, ... ? Let me look at the other headers, I had focused on what OVS used. Is this current patch ok? -- David Marchand