From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19DE6A0353; Tue, 12 Nov 2019 21:34:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BE6E374E; Tue, 12 Nov 2019 21:34:46 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 32EC5374E for ; Tue, 12 Nov 2019 21:34:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573590884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XNA8ruu0kwKdVtJ5pmhDmLeXxBgdtnaHeFrJSdCLPa4=; b=Ja72vOppHyBHbj0vP9ZCNs2BRvLxLXop9x7G6NSB0PgLHZ+Cl54AvSjWgMDsVHgqw1zLnA flNApllvja5ZZ28qOmcnghdwgioxGA2FlQGcumko5E52oyupTYn08laXSLKwdPQvuB4RTq rON3SA+1BYygAt6uh2CCX7Q2Uu7w84U= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-5Nbeoj-cN3qMaqinQAMD7w-1; Tue, 12 Nov 2019 15:34:40 -0500 Received: by mail-vs1-f72.google.com with SMTP id s67so2540381vsc.15 for ; Tue, 12 Nov 2019 12:34:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hHLOd4BIP8aWGsJgYzwqt9q7+X3e7D0tJvNScJoQkrs=; b=BHsNTnkPad9DfbIHV7CCoYLX+Ioi+zSpA207L6aMKq/sTRqQPacfmLJyf5UHN562q8 IbTuCBFDh8O7TzGDu1QVCbgwjvaesWzfmkglV+NEKMfL9F3HUJOdlqRK1kc+RpHBNALH EHtPDbbT240i3sFtjfnJwoLKHHuNXSdzZYc7D8tYfyU4JdyVGY7C1cq5KMbThhqpT1G7 q80BlQMjPlWwuEjmM3/QsImuomaqEOobD2D9x6zVj3OPxZKGFkPy1LFV1aTwf+MW/7C5 iYEDFdnNZPYBq7MKCYcCMpZDnL7GpV2/o80Qp94Spdi9tt99KUOx3KhtsnUy9bZSrDC9 cDfA== X-Gm-Message-State: APjAAAVntZPuGZJTvIpspjxFXEsyK430XkxrMyYIsd87CQIQh+O6lDKv V/lqJezPp5lHMGgmxl0TIlIJzrzqP3B4+5WK56KMH9QXS6n75xIG4MBw5N4B8PsPw/iUbyosyYJ mTBzVooCYq2PMTHV1fwI= X-Received: by 2002:ac5:cbd8:: with SMTP id h24mr2392956vkn.12.1573590879679; Tue, 12 Nov 2019 12:34:39 -0800 (PST) X-Google-Smtp-Source: APXvYqzxqHEFfQp7tyQS+2ZUvqx6nppWHDYvz8/UNpUA6sUQUJf0OvPDUIxjDw4Ys/AduMLu6xXoZTsjOT83AClrsc4= X-Received: by 2002:a67:cfcc:: with SMTP id h12mr23917605vsm.198.1573590878472; Tue, 12 Nov 2019 12:34:38 -0800 (PST) MIME-Version: 1.0 References: <20191108102135.7249-1-kkanas@marvell.com> <20191112082631.GA14417@kk-box-0> In-Reply-To: <20191112082631.GA14417@kk-box-0> From: David Marchand Date: Tue, 12 Nov 2019 21:34:27 +0100 Message-ID: To: Krzysztof Kanas Cc: dev , "Yigit, Ferruh" , Bruce Richardson X-MC-Unique: 5Nbeoj-cN3qMaqinQAMD7w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 0/3] test: fix timeout in flags autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 12, 2019 at 9:29 AM Krzysztof Kanas wrote: > > On 19-11-08 14:45, David Marchand wrote: > > External Email > > > > ---------------------------------------------------------------------- > > On Fri, Nov 8, 2019 at 12:05 PM David Marchand > > wrote: > > > > > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > > > > > Hi David, > > > > > > > > Thanks for review, hopefully this patch will addresses most of the = sutff. > > > > Rest I will address here. > > > > > > > > > > > > > > > + const char *procdir =3D "/proc/self/fd/"; > > > > > > > > > > self is a Linux thing. > > > > > This won't work on FreeBSD. > > > > > > > > IMHO original code didn't worked on FreeBSD as well. > > > > I have created function to adress in third patch > > > > > > Indeed... > > > > > > Well, wait. > > > Why do we need to close those file descriptors? > > > FreeBSD has been like this for quite some time. > > > > We don't know what this is used for. > > > > We know it does not work on FreeBSD, but this does not seem to be a pro= blem. > > Introducing something more on FreeBSD is a risk with no actual benefit > > at first sight. > Ok. > > > > > Either we take only the first patch under a #ifdef EXEC_ENV_LINUX or > > we leave this as is. > I would like have that because ARM64 is main platform for me and this > makes the test pass, and fixes the difference between the comment and > the code. > > > > Krzystof, is this a problem for you if we postpone and investigate > > further for 20.02? > Not a problem. I would like to have fix for EXEC_ENV_LINUX for now. > Rest, FreeBSD case and the decisions weather this whole code should be > deleted can be made later. In my tests of the original code, I never saw anything but access -1 ENOENT= . Anyway, just sent a v4, your v3 patch, with just cosmetics and commitlog updated. --=20 David Marchand