From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 018B3A0C4E; Mon, 8 Nov 2021 21:40:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 944F640151; Mon, 8 Nov 2021 21:40:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 696B640040 for ; Mon, 8 Nov 2021 21:40:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636404042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZycuiM0Z31y6RCjwVbessf0OgsZ4Ot+hobgqMO5YJPo=; b=bS79WoC+1sBU04/RJtYsu2iVpMcf8Zs3vKJ2sGdeUGdKRgk9m0SqlcBzq9d2nqN3941RgV lfgyPklnO4kaxtYhVC85y8v1nD4WNx8n12QTUAhV7JeOZJevB7ChQr10+NusPNbH5dsWaj tQS24KHDrJNDtQzOEij9ReZj9gMp61U= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-118grWRXMuOcaLVhP042Vw-1; Mon, 08 Nov 2021 15:40:41 -0500 X-MC-Unique: 118grWRXMuOcaLVhP042Vw-1 Received: by mail-lf1-f69.google.com with SMTP id y40-20020a0565123f2800b003fded085638so6956047lfa.0 for ; Mon, 08 Nov 2021 12:40:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZycuiM0Z31y6RCjwVbessf0OgsZ4Ot+hobgqMO5YJPo=; b=BpjZaNyKlg/CLSPWYfzHhyWFin/2d9+oeEzoKqxhOsF6H5RTgSwgLVTgdfjGeU//yT f6wEtPLWdz82qF1YJfzHz5pvAJnqWPdoLX6hfEQrOVV7E97kxJ9DkhQNgnANChmYFIep qUfpOS1R9g0jw7N/To6GaomjyUUQ2fI4HxW3AaGZThqLCivIpUuV7Ghvwno46eDTDyK4 kyb9nHB0UYHBBirUtkAw8tkJP1/meHSIGbGwATurnDwY352hrHetoGx0KKKwkf+1SDEF X7K6/xON46UeyKNMB/nLQuEJxDAMBkRbb+9PbHrYx4Fbhf6M4ATFXalBuYELUADIGVgD Fyxg== X-Gm-Message-State: AOAM532bmu5WyWm501n7BEQtisyaQeDcWur7zogq7zG1Y6tS7WtKM6JZ Wj/e+QVUcw0pZ2jlvR+gIIpBNqsmkTxTCgcOuPsS7zlef/IzbtYK1WwC32Cc/oTvyNh7KvlQxC8 jw9F+LVKmDnr4yRZvTIY= X-Received: by 2002:a19:495c:: with SMTP id l28mr1976503lfj.484.1636404040153; Mon, 08 Nov 2021 12:40:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwChRHECsfobYTcAVfd6+3kkQZ/MKJuc0zg/u8Fz77C4DGBq/Vw+Vxz3Y+Vd8mc4/Nnrk74Cy3N8Rumb4P43no= X-Received: by 2002:a19:495c:: with SMTP id l28mr1976478lfj.484.1636404039961; Mon, 08 Nov 2021 12:40:39 -0800 (PST) MIME-Version: 1.0 References: <20211105155351.350403-1-james.r.harris@intel.com> In-Reply-To: <20211105155351.350403-1-james.r.harris@intel.com> From: David Marchand Date: Mon, 8 Nov 2021 21:40:28 +0100 Message-ID: To: Jim Harris Cc: dev , David Hunt Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 5, 2021 at 4:57 PM Jim Harris wrote: > > clang-13 rightfully complains that the tot_ppi > variable in update_stats is set but not used, since > the final accumulated tot_ppi results isn't used > anywhere. > > Original idea was to just remove the tot_ppi variable, > but feedback from David Marchand on mailing list was > that the related ppi_av array in struct priority_worker > wasn't useful and should be removed. This allows us > to also remove num_dequeue_pkts_prev and pc from > struct priority_worker since they are only used in > conjunction with the ppi_av array. This library has its internals exposed to the world for no good reason. I am pretty sure all those structures could be hidden in the .c. It is still an experimental API: we can hope it gets cleaned up at some point. This patch that drops dead code is a first step and lgtm. > > Signed-off-by: Jim Harris Reviewed-by: David Marchand -- David Marchand