From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69E1742B91; Wed, 24 May 2023 22:06:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E17E44067E; Wed, 24 May 2023 22:06:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8455540156 for ; Wed, 24 May 2023 22:06:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684958799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9QA4bZfpJI1wR/e8cXaD61VA3uncRpJDgqysXqdWBpk=; b=B3RvueI8cBkoaSY8nJgSBqqGD44R0apHrWNlBy2n4BmbsIGptZyJwTjhX5ZN6wv1l23jPV P6WnOcTzg0DtxrPE592c9gu9cDHCaa5HDO9dZXlkbQi5WHar4c2xRG/3TUwHQdMisgg/wq 9cH9PkZOaIQWU+fZpTm4EuOLLUxZEQo= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-uWa86FxWOAW0pa2iKEHYJw-1; Wed, 24 May 2023 16:06:37 -0400 X-MC-Unique: uWa86FxWOAW0pa2iKEHYJw-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-1ae4c498f0cso6141615ad.2 for ; Wed, 24 May 2023 13:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684958796; x=1687550796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9QA4bZfpJI1wR/e8cXaD61VA3uncRpJDgqysXqdWBpk=; b=BIgvliHsRqRtuzCY40M8iSkMK+XF00ytwRs+v2Zya+LUsj1nZTTJeSayxLi7ftk1ka ieQykf4ITd7EMiVPn4GtlvNxumWKyFAC4JxNyz6GUCahYwq8dwkJGtgWe6KiuXS619yZ vp9dpkjsjJ/bwGMhW1Yz9976MB2drrwX35LKEkDGtLbcC3xOnlgQq6Y1l0uN3QwispR3 oeH6vcsM4XtyEViIqFNJECRlCl550NED9B4aF3/dURvuGWCnfkBFZFyvn3S3vaRn7v2h DxOGazbFRCMUrnzZFfrWQfh3z8CNwU2Y1zAs/VZkdgE2IH0514XQnImHSnckaJvZclKR xqPA== X-Gm-Message-State: AC+VfDypmOu/q8viaVdUbFqHm/ifUiZiJcopVVdskfoEAPdYflbRRQ+U rA6DJ4XcjQknyHI032dw1K+6t1gg9R5zLyOy+1SAUffg8hYFoXXVjY2XXi9epvsCWHIM2xzTY4x r7O1FoZ+vHzByXbBm7eA= X-Received: by 2002:a17:902:d4c6:b0:1a5:150f:8558 with SMTP id o6-20020a170902d4c600b001a5150f8558mr19429661plg.17.1684958795991; Wed, 24 May 2023 13:06:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7LpqnbKt/m7is4LEQkAVlgSZWU/YvwhbgjYwvfonZKrfqi2OdyyJcyxo3/+tHEdhtD+JpEu4H9OOFrjZ5hvbE= X-Received: by 2002:a17:902:d4c6:b0:1a5:150f:8558 with SMTP id o6-20020a170902d4c600b001a5150f8558mr19429645plg.17.1684958795706; Wed, 24 May 2023 13:06:35 -0700 (PDT) MIME-Version: 1.0 References: <1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com> <1679612036-30773-1-git-send-email-roretzla@linux.microsoft.com> <20230524154701.GA7766@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230524154701.GA7766@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Wed, 24 May 2023 22:06:24 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics To: Tyler Retzlaff Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net, stephen@networkplumber.org, mb@smartsharesystems.com, Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 24, 2023 at 5:47=E2=80=AFPM Tyler Retzlaff wrote: > On Wed, May 24, 2023 at 02:40:43PM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Thu, Mar 23, 2023 at 11:54=E2=80=AFPM Tyler Retzlaff > > wrote: > > > > > > Replace the use of rte_atomic.h types and functions, instead use GCC > > > supplied C++11 memory model builtins. > > > > > > This series covers the libraries and drivers that are built on Window= s. > > > > > > The code has be converted to use the __atomic builtins but there are > > > additional during conversion i notice that there may be some issues > > > that need to be addressed. > > > > > > I'll comment in the patches where my concerns are so the maintainers > > > may comment. > > > > > > v3: > > > * style, don't use c99 comments > > > > > > v2: > > > * comment code where optimizations may be possible now that memory > > > order can be specified. > > > * comment code where operations should potentially be atomic so tha= t > > > maintainers can review. > > > * change a couple of variables labeled as counters to be unsigned. > > > > > > Tyler Retzlaff (7): > > > ring: replace rte atomics with GCC builtin atomics > > > stack: replace rte atomics with GCC builtin atomics > > > dma/idxd: replace rte atomics with GCC builtin atomics > > > net/ice: replace rte atomics with GCC builtin atomics > > > net/ixgbe: replace rte atomics with GCC builtin atomics > > > net/null: replace rte atomics with GCC builtin atomics > > > net/ring: replace rte atomics with GCC builtin atomics > > > > > > drivers/dma/idxd/idxd_internal.h | 3 +-- > > > drivers/dma/idxd/idxd_pci.c | 8 +++++--- > > > drivers/net/ice/ice_dcf.c | 1 - > > > drivers/net/ice/ice_dcf_ethdev.c | 1 - > > > drivers/net/ice/ice_ethdev.c | 12 ++++++++---- > > > drivers/net/ixgbe/ixgbe_bypass.c | 1 - > > > drivers/net/ixgbe/ixgbe_ethdev.c | 18 ++++++++++++------ > > > drivers/net/ixgbe/ixgbe_ethdev.h | 3 ++- > > > drivers/net/ixgbe/ixgbe_flow.c | 1 - > > > drivers/net/ixgbe/ixgbe_rxtx.c | 1 - > > > drivers/net/null/rte_eth_null.c | 28 ++++++++++++++++++---------- > > > drivers/net/ring/rte_eth_ring.c | 26 ++++++++++++++++---------- > > > lib/ring/rte_ring_core.h | 1 - > > > lib/ring/rte_ring_generic_pvt.h | 12 ++++++++---- > > > lib/stack/rte_stack_lf_generic.h | 16 +++++++++------- > > > 15 files changed, 79 insertions(+), 53 deletions(-) > > > > > > > There is still some code using the DPDK "legacy" atomic API, but I > > guess this will be converted later. > > Yes, it will be converted later. > > If I did it correctly... the series was an attempt to move away > from the legacy API where there was a dependency on EAL that would > change when moving to stdatomic. I'm hoping that the remaining use of > the legacy API are not sensitive to the theoretical ABI surface > changing when that move is complete. Ok. > > As you proposed, I dropped patch 1 on the ring library (waiting for > > ARM to provide an alternative) and applied this series, thanks. > > > > Note: Thomas, Ferruh, we will have to be careful when merging subtrees > > to make sure we are not reintroducing those again (like for example > > net/ice). Well, I have some second thought about this series so I did not push it to dpdk.org yet. Drivers maintainers were not copied so I would like another pair of eyes on the series: ideally no /* Note: */ should be left when merging those patches. I'll reply individually on the patches. --=20 David Marchand