From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23DB243688; Wed, 6 Dec 2023 11:08:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A341402CF; Wed, 6 Dec 2023 11:08:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D0D22402C6 for <dev@dpdk.org>; Wed, 6 Dec 2023 11:08:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701857332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FUy3iQLwEsqcSTPDfxVo5myrLscTGWmpYY7e1lPOS3o=; b=TmYMBkKaCrYlIjtU/z7aP8L+CygNprZrT6VzpVPDLKS2jfI+qUTfhBiPrRIwo4owJm2/CZ ncfQt524SQ86MQb+lZX5ApAk+S9ce4orqA3yAM5iu6w+K5csTXt35r1WMPVKl31Rj9JA7F N9Ah2FKAlQgMZvZ9XQl4JgngKo4+mc4= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-TPUkQaE6NWCcUzaYX4PAqQ-1; Wed, 06 Dec 2023 05:08:50 -0500 X-MC-Unique: TPUkQaE6NWCcUzaYX4PAqQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50be79e7f71so2943219e87.2 for <dev@dpdk.org>; Wed, 06 Dec 2023 02:08:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701857329; x=1702462129; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FUy3iQLwEsqcSTPDfxVo5myrLscTGWmpYY7e1lPOS3o=; b=d0umQ5B8QGnii01kT9J0GmLYZDVZZbrlFe6vEeepIGNkrq66eoyJrWCcamSN18/wFS N8+ZnYcJOa2V37z1t8gI5noYQvNn5S+5aMnPFm1hfoo0Gwia9y1BA3MYkxotdWpQHIkB yYKyCx5fJF8QU7olZes0FbjlMm0wuqyE1UHBOHEY+uePyIP+glWibYrUqP0bT1fHqc+X a3nxS8qJZ3DRNAcc1paVvdO9QqH3iQtC453iIM5x+hqlv6OsYpz31YbM1Ge1P+cz1TPE YwYml2z1511QtcbLwntihjgRU72dgGR9Vly59EjX8TYPuWz7qWqtTR//cMMXzMmQzLuZ 44yA== X-Gm-Message-State: AOJu0YxLTccJmKx5M9F8Ww9wQL7Bzx2lgQIADJxcUcOwEP6Ij0j5zw2M kM7gvCwwHhU1PWlXcUO5ZtRcbyqHcIFsyIYoeqgZvdbNb8xg0gzEgAHZsr4+k7bi370d1Njnlr7 8ZSxUoqggxWk019zWEONCLXRtD24= X-Received: by 2002:ac2:48ae:0:b0:50b:f83a:b3ea with SMTP id u14-20020ac248ae000000b0050bf83ab3eamr427986lfg.83.1701857329478; Wed, 06 Dec 2023 02:08:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJ5ViHHt4JZqjoVJpfOSvKTYvLS/fn+6NE/xhbKbma/LyVnpTn/MZgaeGkMPjNohPd8PbAk+qTWQhCX0DCp3I= X-Received: by 2002:ac2:48ae:0:b0:50b:f83a:b3ea with SMTP id u14-20020ac248ae000000b0050bf83ab3eamr427976lfg.83.1701857329114; Wed, 06 Dec 2023 02:08:49 -0800 (PST) MIME-Version: 1.0 References: <20230329234049.11071-1-stephen@networkplumber.org> <20231205021330.260017-1-stephen@networkplumber.org> In-Reply-To: <20231205021330.260017-1-stephen@networkplumber.org> From: David Marchand <david.marchand@redhat.com> Date: Wed, 6 Dec 2023 11:08:37 +0100 Message-ID: <CAJFAV8xvWuBUvgjqUj0f=HyNAX+99Ck=RFWxBcBgFA_Zmj+XGA@mail.gmail.com> Subject: Re: [PATCH 00/18] Convert static log types in libraries to dynamic To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Dec 5, 2023 at 3:13=E2=80=AFAM Stephen Hemminger <stephen@networkplumber.org> wrote: > > This patchset removes most of the uses of static LOGTYPE's in DPDK > libraries. It starts with the easy one and goes on to the more complex on= es. > > There are several options on how to treat the old static types: > leave them there, mark as deprecated, or remove them. > This version removes them since there is no guarantee in current > DPDK policies that says they can't be removed. Those logtypes were internal things that should not have been public in the first place. And switching to a dynamic logtype for external users (if any) is trivial. > > Note: there is one patch in this series that will get > flagged incorrectly as an ABI change. Adding such stable symbols is not a problem. We can ignore this warning (which is there to force maintainers to inspect such additions). > > v14 - rebase on 24.03-rc0 > skip port, table and pipeline libraries since lots of > to be deprecated code. > > v13 - rebase because log now moved. > > v12 - rebase and add table and pipeline libraries > > v11 - fix include check on arm cross build > > v10 - add necessary rte_compat.h in thash_gfni stub for arm > > v9 - fix handling of crc32 alg in lib/hash. > make it an internal global variable. > fix gfni stubs for case where they are not used. > > Stephen Hemminger (18): > gso: don't log message on non TCP/UDP > eal: drop no longer used GSO logtype > log: drop unused RTE_LOGTYPE_TIMER > efd: convert RTE_LOGTYPE_EFD to dynamic type > mbuf: convert RTE_LOGTYPE_MBUF to dynamic type > acl: convert RTE_LOGTYPE_ACL to dynamic type > examples/power: replace use of RTE_LOGTYPE_POWER > examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER > power: convert RTE_LOGTYPE_POWER to dynamic type > ring: convert RTE_LOGTYPE_RING to dynamic type > mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type > lpm: convert RTE_LOGTYPE_LPM to dynamic types > sched: convert RTE_LOGTYPE_SCHED to dynamic type > examples/ipsec-secgw: replace RTE_LOGTYPE_PORT > app/test: remove use of RTE_LOGTYPE_PIPELINE > hash: mover rte_thash_gfni stubs out of header file > hash: move rte_hash_set_alg out of header file > hash: convert RTE_LOGTYPE_HASH to dynamic type > > app/test/test_acl.c | 2 +- > app/test/test_table_acl.c | 50 ++++++++++++------------- > app/test/test_table_pipeline.c | 40 ++++++++++---------- > examples/distributor/main.c | 2 +- > examples/ipsec-secgw/sa.c | 6 +-- > examples/l3fwd-power/main.c | 17 +++++---- > lib/acl/acl.h | 1 + > lib/acl/acl_bld.c | 3 ++ > lib/acl/acl_gen.c | 1 + > lib/acl/acl_log.h | 6 +++ > lib/acl/rte_acl.c | 3 ++ > lib/acl/tb_mem.c | 3 +- > lib/efd/rte_efd.c | 4 ++ > lib/fib/fib_log.h | 4 ++ > lib/fib/rte_fib.c | 3 ++ > lib/fib/rte_fib6.c | 2 + > lib/gso/rte_gso.c | 4 +- > lib/gso/rte_gso.h | 1 + > lib/hash/meson.build | 9 ++++- > lib/hash/rte_crc_arm64.h | 8 ++-- > lib/hash/rte_crc_x86.h | 10 ++--- > lib/hash/rte_cuckoo_hash.c | 5 +++ > lib/hash/rte_fbk_hash.c | 5 +++ > lib/hash/rte_hash_crc.c | 68 ++++++++++++++++++++++++++++++++++ > lib/hash/rte_hash_crc.h | 48 ++---------------------- > lib/hash/rte_thash.c | 3 ++ > lib/hash/rte_thash_gfni.c | 50 +++++++++++++++++++++++++ > lib/hash/rte_thash_gfni.h | 23 +++--------- > lib/hash/version.map | 9 +++++ > lib/log/log.c | 13 ------- > lib/log/rte_log.h | 26 ++++++------- > lib/lpm/lpm_log.h | 4 ++ > lib/lpm/rte_lpm.c | 3 ++ > lib/lpm/rte_lpm6.c | 1 + > lib/mbuf/mbuf_log.h | 4 ++ > lib/mbuf/rte_mbuf.c | 4 ++ > lib/mbuf/rte_mbuf_dyn.c | 2 + > lib/mbuf/rte_mbuf_pool_ops.c | 2 + > lib/mempool/rte_mempool.c | 2 + > lib/mempool/rte_mempool.h | 8 ++++ > lib/mempool/version.map | 3 ++ > lib/power/power_common.c | 2 + > lib/power/power_common.h | 2 + > lib/power/power_kvm_vm.c | 1 + > lib/power/rte_power.c | 1 + > lib/power/rte_power_uncore.c | 1 + > lib/rib/rib_log.h | 4 ++ > lib/rib/rte_rib.c | 3 ++ > lib/rib/rte_rib6.c | 3 ++ > lib/ring/rte_ring.c | 3 ++ > lib/sched/rte_pie.c | 1 + > lib/sched/rte_sched.c | 5 +++ > lib/sched/rte_sched_log.h | 4 ++ > 53 files changed, 329 insertions(+), 163 deletions(-) > create mode 100644 lib/acl/acl_log.h > create mode 100644 lib/fib/fib_log.h > create mode 100644 lib/hash/rte_hash_crc.c > create mode 100644 lib/hash/rte_thash_gfni.c > create mode 100644 lib/lpm/lpm_log.h > create mode 100644 lib/mbuf/mbuf_log.h > create mode 100644 lib/rib/rib_log.h > create mode 100644 lib/sched/rte_sched_log.h I fixed a few issues: - added a release note update for the gso patch, - fixed some styling issues in meson updates, - reordered some hunks and patches, - dropped some whitespace damage and typos, - dropped unneeded include of rte_compat.h, - fixed indent, - marked exported variables as stable (such variable is part of the application ABI), Series applied. --=20 David Marchand