From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4336A04DC; Sat, 31 Oct 2020 23:09:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 099665AA4; Sat, 31 Oct 2020 23:09:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id B86135A0F for ; Sat, 31 Oct 2020 23:09:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604182150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kYm1Us3bzh4Ml5yHMii9s0cGpRxMSuWh2X2xhDv3FYA=; b=LL+JQU76+WrEV7J4wzsZZ0F76060HXUV+k5b/QF//XSyTpE143qyw7d5pm+RZ78UCxKDwj oWwIqt4YYSx+xdZRSscB33oruQOtXYWi8UutUYNeeLHVcoj98g0sruiZq7CHgsE645x4Rm Cp0kwJI/I/ALBAfLWsM6oDkMclcH95Q= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-nQIKdce4PDuccaFFVGezgQ-1; Sat, 31 Oct 2020 18:09:07 -0400 X-MC-Unique: nQIKdce4PDuccaFFVGezgQ-1 Received: by mail-vs1-f70.google.com with SMTP id s7so3128673vso.19 for ; Sat, 31 Oct 2020 15:09:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kYm1Us3bzh4Ml5yHMii9s0cGpRxMSuWh2X2xhDv3FYA=; b=Qb7GE8esyME00dCKMcrFFZ5utq7ANYjgrnVDlb+ty/lEezIpJeTm5IXSjLjjd0Odms wZCHNw4SlqSWXbfDPJLfXbfkIRaeYtyDd5rHOWKnyjMTegv0Nv04NF4s1VzQhnoXiubn 5vS8wEHExJZCf51mkww5hsQKHc2JBInjdkrZWy/cWEuS1lV5kMqK0T/4N37QtKewmp7f r0CpnAMUr1Mac+UsljrgWj25/GX4HTa9fhb5ybs9yxlzKGsLwLcxEB+14qiO5YsuAD7H 3QF1z2nt4vi1J6hJpkoqxrgKNPptTVYfBqI2/DTUyR6FJ4Y86I8+zcK0iOEvxGDcxGxA LUYA== X-Gm-Message-State: AOAM530f6UYj8p0Yaw1tJI6iR3AWGhxygrhYfCchppmQCUhzDAtT1j+x tpNDbiPoSxdD2cWm8nEtQXpphxBsxyvuC+hPgakRfM7xX3vj6tIdvvHBzTEGr/f0kpRssoJZ4hD ibtV399Mx12t2AN/WUUI= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr1558854vsa.10.1604182147353; Sat, 31 Oct 2020 15:09:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWmNEhRYpOuTWwudLrLVOOGhtBizOWoEomPy3B4FNgSsW3Vcgy8cX1LaEByvLKC2H2K8RMQuLoqITo5GafZ70= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr1558852vsa.10.1604182147165; Sat, 31 Oct 2020 15:09:07 -0700 (PDT) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604168282-30079-1-git-send-email-timothy.mcdaniel@intel.com> <1604168282-30079-21-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1604168282-30079-21-git-send-email-timothy.mcdaniel@intel.com> From: David Marchand Date: Sat, 31 Oct 2020 23:08:56 +0100 Message-ID: To: Timothy McDaniel Cc: Ray Kinsella , Neil Horman , dev , Erik Gabriel Carrillo , Gage Eads , Van Haaren Harry , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v14 20/23] event/dlb: add PMD's token pop public interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 31, 2020 at 7:23 PM Timothy McDaniel wrote: > > The PMD uses a public interface to allow applications to > control the token pop mode. Supported token pop modes are > as follows, and they impact core scheduling affinity for > ldb ports. > > AUTO_POP: Pop the CQ tokens immediately after dequeueing. > DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) events > are released. Supported on load-balanced ports > only. > DEFERRED_POP: Pop the CQ tokens during next dequeue operation. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads > --- > doc/api/doxy-api-index.md | 3 +- > drivers/event/dlb/dlb.c | 145 ++++++++++++++++++++++++++++++++++++---- > drivers/event/dlb/dlb_priv.h | 3 + > drivers/event/dlb/meson.build | 4 +- > drivers/event/dlb/rte_pmd_dlb.c | 38 +++++++++++ > drivers/event/dlb/rte_pmd_dlb.h | 77 +++++++++++++++++++++ > drivers/event/dlb/version.map | 6 ++ > 7 files changed, 262 insertions(+), 14 deletions(-) > create mode 100644 drivers/event/dlb/rte_pmd_dlb.c > create mode 100644 drivers/event/dlb/rte_pmd_dlb.h > > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > index a9c12d1..2ff3f74 100644 > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -51,7 +51,8 @@ The public API headers are grouped by topics: > [dpaa2_mempool] (@ref rte_dpaa2_mempool.h), > [dpaa2_cmdif] (@ref rte_pmd_dpaa2_cmdif.h), > [dpaa2_qdma] (@ref rte_pmd_dpaa2_qdma.h), > - [crypto_scheduler] (@ref rte_cryptodev_scheduler.h) > + [crypto_scheduler] (@ref rte_cryptodev_scheduler.h), > + [dlb] (@ref rte_pmd_dlb.h), No comma at the end of the list. Plus, missing the dox-api.conf.in update. > > - **memory**: > [memseg] (@ref rte_memory.h), > diff --git a/drivers/event/dlb/meson.build b/drivers/event/dlb/meson.build > index 552ff9d..7f38c30 100644 > --- a/drivers/event/dlb/meson.build > +++ b/drivers/event/dlb/meson.build > @@ -12,7 +12,9 @@ sources = files('dlb.c', > 'dlb_xstats.c', > 'pf/dlb_main.c', > 'pf/dlb_pf.c', > - 'pf/base/dlb_resource.c' > + 'pf/base/dlb_resource.c', > + 'rte_pmd_dlb.c', > ) > > deps += ['mbuf', 'mempool', 'ring', 'pci', 'bus_pci'] > +install_headers('rte_pmd_dlb.h') We introduced the headers variable, please use it and do not call install_headers directly. -- David Marchand